Hyde\Framework\Concerns\FrontMatter\Schemas\Constructors\PageSchemaConstructor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	makeCanonicalUrl()	0	11	4
A	constructPageSchema()	0	5	1

<?php

namespace Hyde\Framework\Concerns\FrontMatter\Schemas\Constructors;

use Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage;
use Hyde\Framework\Actions\Constructors\FindsTitleForPage;
use Hyde\Framework\Hyde;

trait PageSchemaConstructor
{
    protected function constructPageSchema(): void
    {
        $this->title = FindsTitleForPage::run($this);

The property title does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->navigation = FindsNavigationDataForPage::run($this);

The property navigation does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->canonicalUrl = $this->makeCanonicalUrl();

The property canonicalUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    protected function makeCanonicalUrl(): ?string
    {
        if (! empty($this->matter('canonicalUrl'))) {

It seems like matter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->matter('canonicalUrl');
        }

        if (Hyde::hasSiteUrl() && ! empty($this->identifier)) {
            return $this->getRoute()->getQualifiedUrl();

It seems like getRoute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return null;
    }
}