Application::registerBaseBindings() - Code Metrics - Inspection of "Merge pull request #470 from hydephp/breaking-name..." - hydephp/develop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8207a6...f4663c )

by Caen

created 2022-09-08 15:47 UTC

Application::registerBaseBindings() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	0
dl	0
loc	12
rs	10
c	0
b	0
f	0

<?php

namespace Hyde\Framework\Foundation;

use Illuminate\Filesystem\Filesystem;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Foundation\PackageManifest;

/**
 * @property mixed $app
 */
class Application extends \LaravelZero\Framework\Application
{
    /**
     * {@inheritdoc}
     */
    protected function registerBaseBindings(): void
    {
        parent::registerBaseBindings();

        /*
         * Enable auto-discovery.
         */
        $this->app->singleton(PackageManifest::class, function () {
            return new PackageManifest(
                new Filesystem,
                $this->basePath(),
                $this->basePath('storage/framework/cache/packages.php')
            );
        });
    }
}


1			<?php
2
3			namespace Hyde\Framework\Foundation;
4
5			use Illuminate\Filesystem\Filesystem;
			0 ignored issues – show Bug introduced 2022-09-08 15:50 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Hyde\Framework\Foundation\Filesystem`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Illuminate\Foundation\PackageManifest;
7
8			/**
9			* @property mixed $app
10			*/
11			class Application extends \LaravelZero\Framework\Application
12			{
13			/**
14			* {@inheritdoc}
15			*/
16			protected function registerBaseBindings(): void
17			{
18			parent::registerBaseBindings();
19
20			/*
21			* Enable auto-discovery.
22			*/
23			$this->app->singleton(PackageManifest::class, function () {
24			return new PackageManifest(
25			new Filesystem,
26			$this->basePath(),
27			$this->basePath('storage/framework/cache/packages.php')
28			);
29			});
30			}
31			}
32

hydephp / develop

Push — master ( 8207a6...f4663c )

Application::registerBaseBindings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like