Hyde\Framework\Models\DocumentationSidebar

Complexity

Total Complexity

10

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	findPriorityInConfig()	0	9	2
A	getItemsInGroup()	0	5	2
A	filterHiddenItems()	0	5	2
A	generate()	0	7	1
A	hasGroups()	0	5	1
A	getPriorityForRoute()	0	3	1
A	getGroups()	0	5	1

<?php

namespace Hyde\Framework\Models;

use Hyde\Framework\Models\Pages\DocumentationPage;
use Hyde\Framework\Services\RoutingService;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;

class DocumentationSidebar extends NavigationMenu
{
    public function generate(): self
    {
        RoutingService::getInstance()->getRoutesForModel(DocumentationPage::class)->each(function (Route $route) {
            $this->items->push(NavItem::fromRoute($route)->setPriority($this->getPriorityForRoute($route)));
        });

        return $this;
    }

    public function hasGroups(): bool
    {
        return $this->items->map(function (NavItem $item) {
            return $item->getGroup() !== null;
        })->contains(true);
    }

    public function getGroups(): array
    {
        return $this->items->map(function (NavItem $item) {
            return $item->getGroup();
        })->unique()->toArray();
    }

    public function getItemsInGroup(?string $group): Collection
    {
        return $this->items->filter(function ($item) use ($group) {
            return $item->getGroup() === $group || $item->getGroup() === Str::slug($group);
        })->sortBy('priority')->values();
    }

    protected function filterHiddenItems(): Collection
    {
        return $this->items->reject(function (NavItem $item) {
            return $item->route->getSourceModel()->matter('hidden', false) || ($item->route->getRouteKey() === 'docs/index');

The method matter() does not exist on Hyde\Framework\Contracts\PageContract. It seems like you code against a sub-type of Hyde\Framework\Contracts\PageContract such as Hyde\Framework\Contracts\AbstractMarkdownPage.

        })->values();
    }

    protected function getPriorityForRoute(Route $route): int
    {
        return $route->getSourceModel()->matter('priority') ?? $this->findPriorityInConfig($route->getSourceModel()->slug);

Accessing slug on the interface Hyde\Framework\Contracts\PageContract suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    protected function findPriorityInConfig(string $slug): int
    {
        $orderIndexArray = config('docs.sidebar_order', []);

        if (! in_array($slug, $orderIndexArray)) {
            return 500;
        }

        return array_search($slug, $orderIndexArray) + 250;

        // Adding 250 makes so that pages with a front matter priority that is lower
        // can be shown first. It's lower than the fallback of 500 so that they
        // still come first. This is all to make it easier to mix priorities.
    }
}