Hyde\Framework\Features\XmlGenerators\RssFeedGenerator::addDynamicItemData()

Complexity

Conditions	6
Paths	32

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function addDynamicItemData(SimpleXMLElement $item, MarkdownPost $post): void
    {
        if ($post->getCanonicalUrl() !== null) {
            $this->addChild($item, 'link', $post->getCanonicalUrl());
            $this->addChild($item, 'guid', $post->getCanonicalUrl());
        }

        if (isset($post->date)) {
            $this->addChild($item, 'pubDate', $post->date->format(DATE_RSS));

The method format() does not exist on null.

The method format() does not exist on Hyde\Support\Models\DateString. Since you implemented __call, consider adding a @method annotation.

        }

        if (isset($post->author)) {
            $item->addChild('dc:creator', $post->author->name, 'http://purl.org/dc/elements/1.1/');
        }

        if (isset($post->category)) {
            $this->addChild($item, 'category', $post->category);

It seems like $post->category can also be of type null; however, parameter $value of Hyde\Framework\Features\XmlGenerators\BaseXmlGenerator::addChild() does only seem to accept string, maybe add an additional type check?

        }

        if (isset($post->image)) {
            $image = $item->addChild('enclosure');

            $image->addAttribute('url', Hyde::url($post->image->getSource()));

The method getSource() does not exist on null.

The method url() does not exist on Hyde\Hyde. Since you implemented __callStatic, consider adding a @method annotation.

            $image->addAttribute('type', $this->getImageType($post->image));

It seems like $post->image can also be of type null; however, parameter $image of Hyde\Framework\Features\XmlGenerators\RssFeedGenerator::getImageType() does only seem to accept Hyde\Framework\Features\Blogging\Models\FeaturedImage, maybe add an additional type check?

            $image->addAttribute('length', $this->getImageLength($post->image));

It seems like $post->image can also be of type null; however, parameter $image of Hyde\Framework\Features\XmlGenerators\RssFeedGenerator::getImageLength() does only seem to accept Hyde\Framework\Features\Blogging\Models\FeaturedImage, maybe add an additional type check?

        }