MonitorTask::signalHandler() - Code Metrics - huyanping/log-monitor - Measure and Improve Code Quality continuously with Scrutinizer

MonitorTask::signalHandler() A
last analyzed 2016-07-08 02:38 UTC

↳ Parent: MonitorTask

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php
/**
 * Created by PhpStorm.
 * User: Jenner
 * Date: 2015/10/14
 * Time: 9:34
 */

namespace Jenner\LogMonitor;


use Jenner\LogMonitor\Filter\FilterInterface;
use Jenner\LogMonitor\Notification\NotificationInterface;
use Jenner\LogMonitor\Reader\ReaderInterface;
use Jenner\SimpleFork\Process;

class MonitorTask extends Process
{
    /**
     * @var ReaderInterface
     */
    protected $reader;

    /**
     * @var FilterInterface
     */
    protected $filter;

    /**
     * @var NotificationInterface
     */
    protected $notify;

    /**
     * @param ReaderInterface $reader
     * @param FilterInterface $filter
     * @param NotificationInterface $notify
     */
    public function __construct(
        ReaderInterface $reader,
        FilterInterface $filter,
        NotificationInterface $notify
    )
    {
        parent::__construct();
        $this->reader = $reader;
        $this->filter = $filter;
        $this->notify = $notify;

        $this->registerSignalHandler(SIGTERM, array($this, 'signalHandler'));
    }

    /**
     * sub process run
     */
    public function run()
    {
        $this->reader->open();
        while (true) {
            $line = $this->reader->read();
            if ($line === false) {
                usleep(200);
                continue;
            }
            if ($this->filter->filter($line)) {
                $message = $this->filter->getErrorMessage($line, $this->reader);
                $this->notify->send($this->reader->info(), $message);
            }
        }
    }

    protected function signalHandler($signal)
    {
        switch ($signal) {
            case SIGTERM :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                $this->reader->close();
                unset($this->reader);
                unset($this->filter);
                unset($this->notify);
                exit(0);

        }
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Jenner
5			* Date: 2015/10/14
6			* Time: 9:34
7			*/
8
9			namespace Jenner\LogMonitor;
10
11
12			use Jenner\LogMonitor\Filter\FilterInterface;
13			use Jenner\LogMonitor\Notification\NotificationInterface;
14			use Jenner\LogMonitor\Reader\ReaderInterface;
15			use Jenner\SimpleFork\Process;
16
17			class MonitorTask extends Process
18			{
19			/**
20			* @var ReaderInterface
21			*/
22			protected $reader;
23
24			/**
25			* @var FilterInterface
26			*/
27			protected $filter;
28
29			/**
30			* @var NotificationInterface
31			*/
32			protected $notify;
33
34			/**
35			* @param ReaderInterface $reader
36			* @param FilterInterface $filter
37			* @param NotificationInterface $notify
38			*/
39			public function __construct(
40			ReaderInterface $reader,
41			FilterInterface $filter,
42			NotificationInterface $notify
43			)
44			{
45			parent::__construct();
46			$this->reader = $reader;
47			$this->filter = $filter;
48			$this->notify = $notify;
49
50			$this->registerSignalHandler(SIGTERM, array($this, 'signalHandler'));
51			}
52
53			/**
54			* sub process run
55			*/
56			public function run()
57			{
58			$this->reader->open();
59			while (true) {
60			$line = $this->reader->read();
61			if ($line === false) {
62			usleep(200);
63			continue;
64			}
65			if ($this->filter->filter($line)) {
66			$message = $this->filter->getErrorMessage($line, $this->reader);
67			$this->notify->send($this->reader->info(), $message);
68			}
69			}
70			}
71
72			protected function signalHandler($signal)
73			{
74			switch ($signal) {
75			case SIGTERM :
			0 ignored issues – show Coding Style introduced 2016-07-06 09:27 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
76			$this->reader->close();
77			unset($this->reader);
78			unset($this->filter);
79			unset($this->notify);
80			exit(0);
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-06 09:27 UTC by Report Bug Copy Issue Report The method `signalHandler()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
81			}
82			}
83			}

huyanping / log-monitor

MonitorTask::signalHandler() A last analyzed 2016-07-08 02:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MonitorTask::signalHandler() A
last analyzed 2016-07-08 02:38 UTC