Scheduler\Job\CronRule

Complexity

Total Complexity

8

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRecurrences()	0	15	3
B	getDates()	0	14	5

<?php

namespace Scheduler\Job;

use DateTimeInterface;
use Cron\CronExpression;

/**
 * Class CronRule
 * @package Scheduler\Job
 * @author Aleh Hutnikau, <goodnickoff@gmail.com>
 */
class CronRule extends AbstractRule
{

    /**
     * @param DateTimeInterface $from
     * @param DateTimeInterface $to
     * @param boolean $inc
     * @throws
     * @return DateTimeInterface[]
     */
    public function getRecurrences(DateTimeInterface $from, DateTimeInterface $to, $inc = true)
    {
        $rRule = CronExpression::factory($this->getRrule());
        $result = [];

        if ($from->getTimestamp() < $this->getStartDate()->getTimestamp()) {
            $from = clone $this->getStartDate();
        }

        if (($to->getTimestamp() + (int) $inc) > $this->getStartDate()->getTimestamp()) {
            $result = $this->getDates($rRule, $from, $to, $inc);
        }

        return $result;
    }

    /**
     * @param CronExpression $rRule
     * @param DateTimeInterface $from
     * @param DateTimeInterface $to
     * @param $inc
     * @return DateTimeInterface[]
     */
    private function getDates(CronExpression $rRule, DateTimeInterface $from, DateTimeInterface $to, $inc)
    {
        $firstIteration = true;
        $result = [];
        do {
            $nextRunDate = $rRule->getNextRunDate($from, 0, $firstIteration && $inc);

It seems like $from defined by parameter $from on line 46 can also be of type object<DateTimeInterface>; however, Cron\CronExpression::getNextRunDate() does only seem to accept string|object<DateTime>, maybe add an additional type check?

            if ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc) && $from->getTimestamp() <= $nextRunDate->getTimestamp()) {
                $result[] = $nextRunDate;
            }
            $firstIteration = false;
            $from = $nextRunDate;
        } while ($nextRunDate->getTimestamp() < ($to->getTimestamp() + (int) $inc));
        return $result;
    }
}