Scheduler\ActionInspector\RdsActionInspector

Complexity

Total Complexity

15

Size/Duplication

Total Lines	147
Duplicated Lines	12.24 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	update()	0	30	5
A	getSelectQuery()	0	8	1
A	getUpdateQuery()	8	8	1
A	getInsertQuery()	10	10	1
A	getConnection()	0	4	1
A	getQueryBuilder()	0	4	1
A	initDb()	0	16	2
A	dropDb()	0	11	2

<?php

namespace Scheduler\ActionInspector;

use Scheduler\Action\ActionInterface;
use Scheduler\Exception\SchedulerException;
use Doctrine\DBAL\DBALException;

/**
 * Class RdsActionInspector
 * @package Scheduler\ActionInspector
 * @author Aleh Hutnikau, <goodnickoff@gmail.com>
 */
class RdsActionInspector extends AbstractActionInspector
{
    const TABLE_NAME = 'scheduler_action_inspector';
    const COLUMN_ID = 'id';
    const COLUMN_REPORT = 'report';
    const COLUMN_STATE = 'state';

    /** @var \Doctrine\DBAL\Connection */
    private $connection;

    /**
     * RdsActionInspector constructor.
     * @param \Doctrine\DBAL\Connection $connection
     */
    public function __construct(\Doctrine\DBAL\Connection $connection)
    {
        $this->connection = $connection;
    }

    /**
     * @param ActionInterface $action
     * @return boolean returns `false` if action is already exists in this state in the log
     * @throws SchedulerException
     */
    public function update(ActionInterface $action)
    {
        $actionId = $action->getId();
        $actionState = $action->getState();
        $result = false;
        $previousState = null;
        try {
            $selectQb = $this->getSelectQuery($actionId);

            if ($dbResult = $selectQb->execute()->fetch(\PDO::FETCH_ASSOC)) {
                $previousState = $dbResult[self::COLUMN_STATE];
                $qb = $this->getUpdateQuery($actionState, $actionId);
            } else {
                $qb = $this->getInsertQuery($actionState, $actionId);
            }

            if ($actionState === ActionInterface::STATE_FINISHED) {
                $qb->set(self::COLUMN_REPORT, ':report')
                    ->setParameter(self::COLUMN_REPORT, $action->getReport());
            }

            if ($this->isStateAllowed($action, $previousState)) {
                $result = $qb->execute() === 1;
            }
        } catch (DBALException $e) {
            $result = false;
        }

        return $result;
    }

    /**
     * @param $actionId
     * @return \Doctrine\DBAL\Query\QueryBuilder
     */
    private function getSelectQuery($actionId)
    {
        return $this->getQueryBuilder()
            ->select(implode(',', [self::COLUMN_REPORT, self::COLUMN_STATE, self::COLUMN_ID]))
            ->from(self::TABLE_NAME)
            ->andWhere(self::COLUMN_ID . ' = ?')
            ->setParameter(0, $actionId);
    }

    /**
     * @param $actionState
     * @param $actionId
     * @return \Doctrine\DBAL\Query\QueryBuilder
     */
    private function getUpdateQuery($actionState, $actionId)

This method seems to be duplicated in your project.

    {
        return $this->getQueryBuilder()
            ->update(self::TABLE_NAME)
            ->set(self::COLUMN_STATE, ':state')
            ->where(self::COLUMN_ID . ' = :id')
            ->setParameters(['state' => $actionState, 'id' => $actionId]);
    }

    /**
     * @param $actionState
     * @param $actionId
     * @return \Doctrine\DBAL\Query\QueryBuilder
     */
    private function getInsertQuery($actionState, $actionId)

This method seems to be duplicated in your project.

    {
        return $this->getQueryBuilder()
            ->insert(self::TABLE_NAME)
            ->values([
                self::COLUMN_ID => ':id',
                self::COLUMN_STATE => ':state'
            ])
            ->setParameters(['id' => $actionId, 'state' => $actionState]);
    }

    /**
     * @return \Doctrine\DBAL\Connection
     */
    private function getConnection()
    {
        return $this->connection;
    }

    /**
     * @return \Doctrine\DBAL\Query\QueryBuilder
     */
    private function getQueryBuilder()
    {
        return $this->getConnection()->createQueryBuilder();
    }

    /**
     * @param \Doctrine\DBAL\Connection $connection
     * @throws \Doctrine\DBAL\DBALException
     */
    public static function initDb(\Doctrine\DBAL\Connection $connection)
    {
        $schemaManager = $connection->getSchemaManager();
        $schema = $schemaManager->createSchema();
        $fromSchema = clone $schema;
        $table = $schema->createTable(self::TABLE_NAME);
        $table->addColumn(static::COLUMN_ID, 'string', ['length' => 255, 'notnull' => true]);
        $table->addColumn(static::COLUMN_STATE, 'string', ['length' => 255, 'notnull' => true]);
        $table->addColumn(static::COLUMN_REPORT, 'text', ['notnull' => false]);
        $table->setPrimaryKey([static::COLUMN_ID]);
        $table->addIndex([static::COLUMN_ID], 'IDX_' . static::TABLE_NAME . '_' . static::COLUMN_ID);
        $queries = $fromSchema->getMigrateToSql($schema, $connection->getDatabasePlatform());
        foreach ($queries as $query) {
            $connection->exec($query);
        }
    }

    public static function dropDb(\Doctrine\DBAL\Connection $connection)
    {
        $schemaManager = $connection->getSchemaManager();
        $schema = $schemaManager->createSchema();
        $fromSchema = clone $schema;
        $schema->dropTable(self::TABLE_NAME);
        $queries = $fromSchema->getMigrateToSql($schema, $connection->getDatabasePlatform());
        foreach ($queries as $query) {
            $connection->exec($query);
        }
    }
}