hustoj / hustoj-neo

app/Services/JudgerService.php

<?php

namespace App\Services;

use App\Entities\Judger;
use App\Exceptions\Judger\JudgerNameExist;
use App\Repositories\JudgerRepository;

class JudgerService
{
    /**
     * @param string $name
     * @param null   $bind_ip

Are you sure the doc-type for parameter $bind_ip is correct as it would always require null to be passed?

     *
     * @throws \App\Exceptions\Judger\JudgerNameExist
     *
     * @return \App\Entities\Judger
     */
    public function newJudger($name, $bind_ip = null)
    {
        if ($this->exist($name)) {
            throw new JudgerNameExist();
        }
        $judger = new Judger();
        $judger->name = $name;
        $judger->code = new_judge_code();
        $judger->status = Judger::ST_ACTIVITY;
        if ($bind_ip) {

$bind_ip is of type null, thus it always evaluated to false.

            $judger->bind_ip = $bind_ip;
        }
        $judger->save();

        return $judger;
    }

    private function exist($name)
    {
        return app(JudgerRepository::class)->findBy('name', $name);
    }

    public function find($id)
    {
        return app(JudgerRepository::class)->findOrFail($id);
    }

    /**
     * @param $code
     *
     * @return Judger
     */
    public function getJudger($code)
    {
        if ($code) {
            return app(JudgerRepository::class)->findBy('code', $code);
        }

        return null;
    }
}