ContestManager::update() - Code Metrics - Inspection of "refactor(contest): refactor contest manager code" - hustoj/hustoj-neo - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 60f940...0da644 )

by he

created 2020-09-06 14:55 UTC

ContestManager::update() A

↳ Parent: ContestManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
nc	1
nop	4
dl	0
loc	8
rs	10
c	1
b	0
f	0

<?php

namespace App\Services\Contest;

use App\Entities\Contest;
use Carbon\Carbon;

class ContestManager
{
    /**
     * @param array $attrs
     * @param string $startAt
     * @param string $endAt
     *
     * @return \App\Entities\Contest
     */
    public function create($attrs, $startAt, $endAt) {
        $model = new Contest();

        return $this->update($model, $attrs, $startAt, $endAt);
    }

    /**
     * @param Contest $contest
     * @param array $attrs
     * @param string $startAt
     * @param string $endAt
     *
     * @return \App\Entities\Contest
     */
    public function update($contest, $attrs, $startAt, $endAt) {
        $contest->fill($attrs);
        $contest->start_time = Carbon::parse($startAt);
        $contest->end_time = Carbon::parse($endAt);

        $contest->save();

        return $contest;
    }

    /**
     * @param Contest $contest
     * @param array $problemIds
     */
    public function syncProblems($contest, $problemIds) {
        $relations = [];
        $index = 0;
        foreach ($problemIds as $id) {
            $relations[$id] = ['order' => $index];
            $index++;
        }
        $contest->problems()->sync($relations);
    }

    /**
     * @param Contest $contest
     * @param array $userIds
     */
    public function syncUser($contest, $userIds) {
        $contest->users()->sync($userIds);
    }
}


1			<?php
2
3			namespace App\Services\Contest;
4
5			use App\Entities\Contest;
6			use Carbon\Carbon;
7
8			class ContestManager
9			{
10			/**
11			* @param array $attrs
12			* @param string $startAt
13			* @param string $endAt
14			*
15			* @return \App\Entities\Contest
16			*/
17			public function create($attrs, $startAt, $endAt) {
18			$model = new Contest();
19
20			return $this->update($model, $attrs, $startAt, $endAt);
21			}
22
23			/**
24			* @param Contest $contest
25			* @param array $attrs
26			* @param string $startAt
27			* @param string $endAt
28			*
29			* @return \App\Entities\Contest
30			*/
31			public function update($contest, $attrs, $startAt, $endAt) {
32			$contest->fill($attrs);
33			$contest->start_time = Carbon::parse($startAt);
34			$contest->end_time = Carbon::parse($endAt);
35
36			$contest->save();
37
38			return $contest;
39			}
40
41			/**
42			* @param Contest $contest
43			* @param array $problemIds
44			*/
45			public function syncProblems($contest, $problemIds) {
46			$relations = [];
47			$index = 0;
48			foreach ($problemIds as $id) {
49			$relations[$id] = ['order' => $index];
50			$index++;
51			}
52			$contest->problems()->sync($relations);
53			}
54
55			/**
56			* @param Contest $contest
57			* @param array $userIds
58			*/
59			public function syncUser($contest, $userIds) {
60			$contest->users()->sync($userIds);
61			}
62			}
63

hustoj / hustoj-neo

Push — master ( 60f940...0da644 )

ContestManager::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like