JudgerService::newJudger() - Code Metrics - Inspection of "Merge branch 'feature/judger_api'" - hustoj/hustoj-neo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 395fb2...b0764c )

by he

created 2019-09-03 16:22 UTC

JudgerService::newJudger() A

↳ Parent: JudgerService

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	3
eloc	10
c	1
b	0
f	1
nc	3
nop	2
dl	0
loc	15
rs	9.9332

<?php

namespace App\Services;

use App\Entities\Judger;
use App\Exceptions\Judger\JudgerNameExist;
use App\Repositories\JudgerRepository;

class JudgerService
{
    /**
     * @param string $name
     * @param null   $bind_ip

     *
     * @throws \App\Exceptions\Judger\JudgerNameExist
     *
     * @return \App\Entities\Judger
     */
    public function newJudger($name, $bind_ip = null)
    {
        if ($this->exist($name)) {
            throw new JudgerNameExist();
        }
        $judger = new Judger();
        $judger->name = $name;
        $judger->code = new_judge_code();
        $judger->status = Judger::ST_ACTIVITY;
        if ($bind_ip) {

            $judger->bind_ip = $bind_ip;
        }
        $judger->save();

        return $judger;
    }

    public function find($id)
    {
        return app(JudgerRepository::class)->findOrFail($id);
    }
    /**
     * @param $code
     *
     * @return Judger
     */
    public function getJudger($code)
    {
        if ($code) {
            return app(JudgerRepository::class)->findBy('code', $code);
        }

        return null;
    }

    private function exist($name)
    {
        return app(JudgerRepository::class)->findBy('name', $name);
    }
}


1			<?php
2
3			namespace App\Services;
4
5			use App\Entities\Judger;
6			use App\Exceptions\Judger\JudgerNameExist;
7			use App\Repositories\JudgerRepository;
8
9			class JudgerService
10			{
11			/**
12			* @param string $name
13			* @param null $bind_ip
			0 ignored issues – show Documentation Bug introduced 2019-09-03 16:33 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$bind_ip` is correct as it would always require `null` to be passed? Loading history...
14			*
15			* @throws \App\Exceptions\Judger\JudgerNameExist
16			*
17			* @return \App\Entities\Judger
18			*/
19			public function newJudger($name, $bind_ip = null)
20			{
21			if ($this->exist($name)) {
22			throw new JudgerNameExist();
23			}
24			$judger = new Judger();
25			$judger->name = $name;
26			$judger->code = new_judge_code();
27			$judger->status = Judger::ST_ACTIVITY;
28			if ($bind_ip) {
			0 ignored issues – show introduced 2019-09-03 16:33 UTC by Report Bug Copy Issue Report `$bind_ip` is of type `null`, thus it always evaluated to `false`. Loading history...
29			$judger->bind_ip = $bind_ip;
30			}
31			$judger->save();
32
33			return $judger;
34			}
35
36			public function find($id)
37			{
38			return app(JudgerRepository::class)->findOrFail($id);
39			}
40			/**
41			* @param $code
42			*
43			* @return Judger
44			*/
45			public function getJudger($code)
46			{
47			if ($code) {
48			return app(JudgerRepository::class)->findBy('code', $code);
49			}
50
51			return null;
52			}
53
54			private function exist($name)
55			{
56			return app(JudgerRepository::class)->findBy('name', $name);
57			}
58			}
59

hustoj / hustoj-neo

Push — master ( 395fb2...b0764c )

JudgerService::newJudger() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like