App\Http\Controllers\Admin\HomeController::chart()

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function chart()
    {
        $result = [];

        $from = Carbon::create(null, null, null, 0, 0, 0);
        $from = $from->subDays(request('from'));

request('from') of type Illuminate\Http\Request|array|string is incompatible with the type integer expected by parameter $value of Carbon\Carbon::subDays().

        $result['user'] = app(UserService::class)->getUserStats($from);

It seems like $from can also be of type false; however, parameter $from of App\Services\UserService::getUserStats() does only seem to accept Carbon\Carbon, maybe add an additional type check?

        $result['submission'] = app(SolutionService::class)->getSubmissionStats($from);

It seems like $from can also be of type false; however, parameter $from of App\Services\SolutionService::getSubmissionStats() does only seem to accept Carbon\Carbon, maybe add an additional type check?

        return $result;
    }