App\Console\Commands\CreateNewJudger

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	9	3

<?php

namespace App\Console\Commands;

use App\Exceptions\ApiException;
use App\Services\JudgerService;
use Illuminate\Console\Command;

class CreateNewJudger extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'judger:new {name}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'create new judger';

    public function handle()
    {
        $name = $this->argument('name');
        if ($name) {
            try {
                $judger = app(JudgerService::class)->newJudger($name);

It seems like $name can also be of type array; however, parameter $name of App\Services\JudgerService::newJudger() does only seem to accept string, maybe add an additional type check?

                $this->info("Create New Judger {$name}, Code: ".$judger->code);
            } catch (ApiException $e) {
                $this->error($e->getMessage());
            }
        }
    }
}