Issues in UpdatesModelRelations.php (1.0.0-alpha) - Issues in 1.0.0-alpha - huntie/laravel-simple-jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Concerns/UpdatesModelRelations.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Huntie\JsonApi\Http\Concerns;

use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;

/**
 * Specify and update relationships on the primary controller resource.
 *
 * @property $model
 */
trait UpdatesModelRelations
{
    /**
     * The model relationships that can be updated.
     *
     * @var array
     */
    protected $fillableRelations = [];

    /**
     * Determine whether the given named relation can be updated on the model.
     *
     * @param string $relation
     */
    protected function isFillableRelation(string $relation): bool
    {
        return array_key_exists($relation, $this->fillableRelations);
    }

    /**
     * Determine the JSON API relation type for a named relation on the primary
     * resource.
     *
     * @param string $relation
     *
     * @return string|void
     */
    protected function getRelationType(string $relation)
    {
        $relation = $this->model->{$relation}();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($relation instanceof BelongsTo) {
            return 'To-One';
        } else if ($relation instanceof BelongsToMany) {
            return 'To-Many';
        }
    }

    /**
     * Update a named many-to-one relationship association on a model instance.
     *
     * http://jsonapi.org/format/#crud-updating-to-one-relationships
     *
     * @param Model  $record
     * @param string $relation
     * @param array  $data
     */
    protected function updateToOneResourceRelationship($record, string $relation, array $data)
    {
        $record->{$relation}()->associate($data['id']);
        $record->save();
    }

    /**
     * Update named many-to-many relationship entries on a model instance.
     *
     * http://jsonapi.org/format/#crud-updating-to-many-relationships
     *
     * @param Model  $record
     * @param string $relation
     * @param array  $data
     * @param string $method
     */
    protected function updateToManyResourceRelationship($record, string $relation, array $data, string $method)
    {
        $items = [];

        foreach ($data as $item) {
            if (isset($item['attributes'])) {
                $items[$item['id']] = $item['attributes'];
            } else {
                $items[] = $item['id'];
            }
        }

        switch ($method) {
            case 'PATCH':
                $record->{$relation}()->sync($items);
                break;
            case 'POST':
                $record->{$relation}()->sync($items, false);
                break;
            case 'DELETE':
                $record->{$relation}()->detach(array_keys($items));
        }
    }

    /**
     * Update one or more relationships on a model instance from an array of
     * named relationships and associated resource identifiers.
     *
     * http://jsonapi.org/format/#crud-updating-resource-relationships
     *
     * @param Model $record
     * @param array $relationships
     */
    protected function updateResourceRelationships($record, array $relationships)
    {
        $relationships = array_intersect_key($relationships, array_flip($this->fillableRelations));

        foreach ($relationships as $name => $relationship) {
            if ($this->getRelationType($name) === 'To-One') {
                $record->{$name}()->associate(array_get($relationship, 'data.id'));
                $record->save();
            } else if ($this->getRelationType($name) === 'To-Many') {
                $record->{$name}()->sync(array_pluck($relationship['data'], 'id'));
            }
        }
    }
}


1			<?php
2
3			namespace Huntie\JsonApi\Http\Concerns;
4
5			use Illuminate\Database\Eloquent\Relations\BelongsTo;
6			use Illuminate\Database\Eloquent\Relations\BelongsToMany;
7
8			/**
9			* Specify and update relationships on the primary controller resource.
10			*
11			* @property $model
12			*/
13			trait UpdatesModelRelations
14			{
15			/**
16			* The model relationships that can be updated.
17			*
18			* @var array
19			*/
20			protected $fillableRelations = [];
21
22			/**
23			* Determine whether the given named relation can be updated on the model.
24			*
25			* @param string $relation
26			*/
27			protected function isFillableRelation(string $relation): bool
28			{
29			return array_key_exists($relation, $this->fillableRelations);
30			}
31
32			/**
33			* Determine the JSON API relation type for a named relation on the primary
34			* resource.
35			*
36			* @param string $relation
37			*
38			* @return string\|void
39			*/
40			protected function getRelationType(string $relation)
41			{
42			$relation = $this->model->{$relation}();
			0 ignored issues – show Bug introduced 2017-03-15 22:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43
44			if ($relation instanceof BelongsTo) {
45			return 'To-One';
46			} else if ($relation instanceof BelongsToMany) {
47			return 'To-Many';
48			}
49			}
50
51			/**
52			* Update a named many-to-one relationship association on a model instance.
53			*
54			* http://jsonapi.org/format/#crud-updating-to-one-relationships
55			*
56			* @param Model $record
57			* @param string $relation
58			* @param array $data
59			*/
60			protected function updateToOneResourceRelationship($record, string $relation, array $data)
61			{
62			$record->{$relation}()->associate($data['id']);
63			$record->save();
64			}
65
66			/**
67			* Update named many-to-many relationship entries on a model instance.
68			*
69			* http://jsonapi.org/format/#crud-updating-to-many-relationships
70			*
71			* @param Model $record
72			* @param string $relation
73			* @param array $data
74			* @param string $method
75			*/
76			protected function updateToManyResourceRelationship($record, string $relation, array $data, string $method)
77			{
78			$items = [];
79
80			foreach ($data as $item) {
81			if (isset($item['attributes'])) {
82			$items[$item['id']] = $item['attributes'];
83			} else {
84			$items[] = $item['id'];
85			}
86			}
87
88			switch ($method) {
89			case 'PATCH':
90			$record->{$relation}()->sync($items);
91			break;
92			case 'POST':
93			$record->{$relation}()->sync($items, false);
94			break;
95			case 'DELETE':
96			$record->{$relation}()->detach(array_keys($items));
97			}
98			}
99
100			/**
101			* Update one or more relationships on a model instance from an array of
102			* named relationships and associated resource identifiers.
103			*
104			* http://jsonapi.org/format/#crud-updating-resource-relationships
105			*
106			* @param Model $record
107			* @param array $relationships
108			*/
109			protected function updateResourceRelationships($record, array $relationships)
110			{
111			$relationships = array_intersect_key($relationships, array_flip($this->fillableRelations));
112
113			foreach ($relationships as $name => $relationship) {
114			if ($this->getRelationType($name) === 'To-One') {
115			$record->{$name}()->associate(array_get($relationship, 'data.id'));
116			$record->save();
117			} else if ($this->getRelationType($name) === 'To-Many') {
118			$record->{$name}()->sync(array_pluck($relationship['data'], 'id'));
119			}
120			}
121			}
122			}
123

huntie / laravel-simple-jsonapi

Issues (31)

Security Analysis not enabled

src/Http/Concerns/UpdatesModelRelations.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like