Huntie\JsonApi\Routing\ResourceRegistrar

Complexity

Total Complexity

8

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	register()	0	6	1
A	registerRelationships()	0	18	3
A	addRelationshipShow()	0	8	1
A	addRelationshipUpdate()	0	8	1
A	getRelationshipUri()	0	4	1

<?php

namespace Huntie\JsonApi\Routing;

class ResourceRegistrar extends \Illuminate\Routing\ResourceRegistrar
{
    /**
     * The default actions for a resourceful controller.
     *
     * @var array
     */
    protected $resourceDefaults = ['index', 'store', 'show', 'update', 'destroy'];

    /**
     * The default actions for each named resource relationship.
     *
     * @var array
     */
    protected $relationshipDefaults = ['show'];

    /**
     * Create a new resource registrar instance.
     *
     * @param \Huntie\JsonApi\Routing\Router $router
     */
    public function __construct(Router $router)
    {
        $this->router = $router;
    }

    /**
     * Route a resource to a controller.
     *
     * @param string $name
     * @param string $controller
     * @param array  $options
     */
    public function register($name, $controller, array $options = [])
    {
        parent::register($name, $controller, $options);

        $this->registerRelationships($name, $controller, $options);
    }

    /**
     * Route any resource relationships to a controller.
     *
     * @param string $name
     * @param string $controller
     * @param array  $options
     */
    protected function registerRelationships(string $name, string $controller, array $options)
    {
        // Map non-associative members as keys, with default relationship actions
        $relationships = collect(array_get($options, 'relationships', []))
            ->mapWithKeys(function ($methods, $relationship) {
                return is_numeric($relationship)
                    ? [$methods => $this->relationshipDefaults]
                    : [$relationship => (array) $methods];
            });

        foreach (['show', 'update'] as $action) {
            $matched = (array) $relationships->filter(function ($methods) use ($action) {
                return in_array($action, $methods);
            });

            $this->{'addRelationship' . ucfirst($action)}($name, $base, $matched, $controller, $options);

The variable $base does not exist. Did you forget to declare it?

        }
    }

    /**
     * Add a relationship show method to match named relationships on the resource.
     *
     * @param string $name
     * @param string $base
     * @param array  $relationships
     * @param string $controller
     * @param array  $options
     *
     * @return \Illuminate\Routing\Route
     */
    protected function addRelationshipShow(string $name, string $base, array $relationships, string $controller, array $options)

This line exceeds maximum limit of 120 characters; contains 128 characters

    {
        $uri = $this->getRelationshipUri($name, $base);
        $action = $this->getResourceAction($name, $controller, 'showRelationship', $options);

        return $this->router->get($uri, $action)
            ->where('relationship', '(' . implode(')|(', $relationships) . ')');
    }

    /**
     * Add a relationship update method to match named relationships on the resource.
     *
     * @param string $name
     * @param string $base
     * @param array  $relationships
     * @param string $controller
     * @param array  $options
     *
     * @return \Illuminate\Routing\Route
     */
    protected function addRelationshipUpdate(string $name, string $base, array $relationships, string $controller, array $options)

This line exceeds maximum limit of 120 characters; contains 130 characters

    {
        $uri = $this->getRelationshipUri($name, $base);
        $action = $this->getResourceAction($name, $relationships, $controller, 'updateRelationship', $options);

$relationships is of type array, but the function expects a string.

'updateRelationship' is of type string, but the function expects a array.

The call to ResourceRegistrar::getResourceAction() has too many arguments starting with $options.

        return $this->router->match(['PUT', 'PATCH'], $uri, $action)
            ->where('relationship', '(' . implode(')|(', $relationships) . ')');
    }

    /**
     * Get the URI for resource relationships.
     *
     * @param string $name
     * @param string $base
     */
    public function getRelationshipUri(string $name, string $base): string
    {
        return sprintf('%s/{%s}/relationships/{relationship}', $this->getResourceUri($name), $base);
    }
}