JsonApiControllerActions::relationship() - Code Metrics - Inspection of "Validate supported Content-Type header values in b..." - huntie/laravel-simple-jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — request-validation ( 81884a...ddd2e2 )

by Alex

created 2017-03-15 22:45 UTC

JsonApiControllerActions::relationship() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	4
rs	10
c	1
b	0
f	0
nc	1
cc	1
eloc	2
nop	3

<?php

namespace Huntie\JsonApi\Http\Controllers;

use Huntie\JsonApi\Http\Requests\ListResourceRequest;
use Huntie\JsonApi\Http\Requests\StoreResourceRequest;
use Huntie\JsonApi\Http\Requests\ShowResourceRequest;
use Huntie\JsonApi\Http\Requests\UpdateResourceRequest;
use Huntie\JsonApi\Http\Requests\DestroyResourceRequest;
use Huntie\JsonApi\Http\Requests\ShowRelationshipRequest;

/**
 * Add default resource controller methods for JsonApiController actions.
 *
 * @return JsonApiController
 */
trait JsonApiControllerActions
{
    /**
     * Return a listing of the resource.
     *
     * @param ListResourceRequest $request
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function index(ListResourceRequest $request)
    {
        return $this->indexAction($request);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Store a new record.
     *
     * @param StoreResourceRequest $request
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function store(StoreResourceRequest $request)
    {
        return $this->storeAction($request);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Return a specified record.
     *
     * @param ShowResourceRequest $request
     * @param int                 $id
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function show(ShowResourceRequest $request, $id)
    {
        return $this->showAction($request, $id);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Update a specified record.
     *
     * @param UpdateResourceRequest $request
     * @param int                   $id
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function update(UpdateResourceRequest $request, $id)
    {
        return $this->updateAction($request, $id);

    }

    /**
     * Destroy a specified record.
     *
     * @param DestroyResourceRequest $request
     * @param int                    $id
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function destroy(DestroyResourceRequest $request, $id)
    {
        return $this->destroyAction($request, $id);

    }

    /**
     * Return a specified record relationship.
     *
     * @param ShowRelationshipRequest $request
     * @param int                     $id
     * @param string                  $relation
     *
     * @return \Huntie\JsonApi\Http\JsonApiResponse
     */
    public function showRelationship(ShowRelationshipRequest $request, $id, $relation)
    {
        return $this->showRelationshipAction($request, $id, $relation);

    }
}


1			<?php
2
3			namespace Huntie\JsonApi\Http\Controllers;
4
5			use Huntie\JsonApi\Http\Requests\ListResourceRequest;
6			use Huntie\JsonApi\Http\Requests\StoreResourceRequest;
7			use Huntie\JsonApi\Http\Requests\ShowResourceRequest;
8			use Huntie\JsonApi\Http\Requests\UpdateResourceRequest;
9			use Huntie\JsonApi\Http\Requests\DestroyResourceRequest;
10			use Huntie\JsonApi\Http\Requests\ShowRelationshipRequest;
11
12			/**
13			* Add default resource controller methods for JsonApiController actions.
14			*
15			* @return JsonApiController
16			*/
17			trait JsonApiControllerActions
18			{
19			/**
20			* Return a listing of the resource.
21			*
22			* @param ListResourceRequest $request
23			*
24			* @return \Huntie\JsonApi\Http\JsonApiResponse
25			*/
26			public function index(ListResourceRequest $request)
27			{
28			return $this->indexAction($request);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report It seems like `indexAction()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			}
30
31			/**
32			* Store a new record.
33			*
34			* @param StoreResourceRequest $request
35			*
36			* @return \Huntie\JsonApi\Http\JsonApiResponse
37			*/
38			public function store(StoreResourceRequest $request)
39			{
40			return $this->storeAction($request);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report It seems like `storeAction()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42
43			/**
44			* Return a specified record.
45			*
46			* @param ShowResourceRequest $request
47			* @param int $id
48			*
49			* @return \Huntie\JsonApi\Http\JsonApiResponse
50			*/
51			public function show(ShowResourceRequest $request, $id)
52			{
53			return $this->showAction($request, $id);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report It seems like `showAction()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			}
55
56			/**
57			* Update a specified record.
58			*
59			* @param UpdateResourceRequest $request
60			* @param int $id
61			*
62			* @return \Huntie\JsonApi\Http\JsonApiResponse
63			*/
64			public function update(UpdateResourceRequest $request, $id)
65			{
66			return $this->updateAction($request, $id);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report The method `updateAction()` does not exist on `Huntie\JsonApi\Http\Cont...sonApiControllerActions`. Did you maybe mean `update()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
67			}
68
69			/**
70			* Destroy a specified record.
71			*
72			* @param DestroyResourceRequest $request
73			* @param int $id
74			*
75			* @return \Huntie\JsonApi\Http\JsonApiResponse
76			*/
77			public function destroy(DestroyResourceRequest $request, $id)
78			{
79			return $this->destroyAction($request, $id);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report The method `destroyAction()` does not exist on `Huntie\JsonApi\Http\Cont...sonApiControllerActions`. Did you maybe mean `destroy()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
80			}
81
82			/**
83			* Return a specified record relationship.
84			*
85			* @param ShowRelationshipRequest $request
86			* @param int $id
87			* @param string $relation
88			*
89			* @return \Huntie\JsonApi\Http\JsonApiResponse
90			*/
91			public function showRelationship(ShowRelationshipRequest $request, $id, $relation)
92			{
93			return $this->showRelationshipAction($request, $id, $relation);
			0 ignored issues – show Bug introduced 2017-03-15 21:55 UTC by Report Bug Copy Issue Report The method `showRelationshipAction()` does not exist on `Huntie\JsonApi\Http\Cont...sonApiControllerActions`. Did you maybe mean `showRelationship()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
94			}
95			}
96

huntie / laravel-simple-jsonapi

Push — request-validation ( 81884a...ddd2e2 )

JsonApiControllerActions::relationship() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like