EFParser\Sheet

Complexity

Total Complexity

4

Size/Duplication

Total Lines	70
Duplicated Lines	25.71 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	readActiveSheet()	0	9	1
A	readSheetByName()	9	9	1
A	readSheetByIndex()	9	9	1

<?php

namespace EFParser;

use EFParserInterface\ISheetParser,
    EFParserInterface\IExcel;

/**
 * Class Sheet
 * Класс для парсинга листов
 */
class Sheet implements ISheetParser
{
    private $parser;

    /**
     * Конструктор
     *
     * @param IExcel $excel (Класс реализующий IExcel интерфейс)
     */
    public function __construct(IExcel $excel)
    {
        $this->parser = $excel;
    }

    /**
     * Метод чтения документа (c активного листа).
     *
     * @return array    (Содержимое документа)
     *
     * @throws PHPExcel_Reader_Exception
     */
    public function readActiveSheet()
    {
        $objPHPExcel = $this->parser->sourceReader

Accessing sourceReader on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->load($this->parser->sourceFilePath.$this->parser->sourceFile)

Accessing sourceFilePath on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing sourceFile on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->getActiveSheet()
                                    ->toArray();

        return $this->parser->getData($objPHPExcel);
    }

    /**
     * Метод для чтения отдельного листа (по названию).
     *
     * @param string $sheetName      (Название листа)
     *
     * @return array                 (Содержимое документа)
     *
     * @throws PHPExcel_Reader_Exception
     */
    public function readSheetByName($sheetName)

This method seems to be duplicated in your project.

    {
        $objPHPExcel = $this->parser->sourceReader

Accessing sourceReader on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->load($this->parser->sourceFilePath.$this->parser->sourceFile)

Accessing sourceFilePath on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing sourceFile on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->getSheetByName($sheetName)
                                    ->toArray();

        return $this->parser->getData($objPHPExcel);
    }

    /**
     * Метод для чтения отдельного листа (по индексу).
     *
     * @param int $sheetIndex   (Индекс листа (счит.с 0))
     *
     * @return array            (Содержимое документа)
     *
     * @throws PHPExcel_Exception
     * @throws PHPExcel_Reader_Exception
     */
    public function readSheetByIndex($sheetIndex)

This method seems to be duplicated in your project.

    {
        $objPHPExcel = $this->parser->sourceReader

Accessing sourceReader on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->load($this->parser->sourceFilePath.$this->parser->sourceFile)

Accessing sourceFilePath on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing sourceFile on the interface EFParserInterface\IExcel suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->getSheet($sheetIndex)
                                    ->toArray();

        return $this->parser->getData($objPHPExcel);
    }
}