Manager::__construct() - Code Metrics - Inspection of "fix codecoverage" - humweb/sociable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3f2f54...ead273 )

by Ryun

created 2016-08-05 21:00 UTC

Manager::__construct() A

↳ Parent: Manager

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	2
eloc	2
nc	2
nop	1

<?php

namespace Humweb\Sociable\Auth;

use Illuminate\Container\Container;
use Illuminate\Support\Manager as BaseManager;

/**
 * Manager
 *
 * @package Humweb\SociableConnection\Auth
 */
class Manager extends BaseManager
{

    /**
     * Create a new manager instance.
     *
     * @param  \Illuminate\Foundation\Application  $app
     * @return void

     */
    public function __construct($app = null)
    {
        $this->app = $app ?: Container::getInstance();
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }


    /**
     * Create Laravel driver
     *
     * @return \Humweb\Sociable\Auth\LaravelDriver
     */
    protected function createLaravelDriver()
    {
        return new LaravelDriver($this->app);
    }


    /**
     * @return \Humweb\Sociable\Auth\SentinelDriver
     */
    protected function createSentinelDriver()
    {
        return new SentinelDriver($this->app);
    }


    /**
     * Get the default driver name.
     *
     * @return string
     */
    public function getDefaultDriver()
    {
        return $this->app['config']->get('social.auth_provider', 'laravel');
    }
}

1			<?php
2
3			namespace Humweb\Sociable\Auth;
4
5			use Illuminate\Container\Container;
6			use Illuminate\Support\Manager as BaseManager;
7
8			/**
9			* Manager
10			*
11			* @package Humweb\SociableConnection\Auth
12			*/
13			class Manager extends BaseManager
14			{
15
16			/**
17			* Create a new manager instance.
18			*
19			* @param \Illuminate\Foundation\Application $app
20			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-08-05 21:15 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
21			*/
22			public function __construct($app = null)
23			{
24			$this->app = $app ?: Container::getInstance();
			0 ignored issues – show Documentation Bug introduced 2016-08-05 21:15 UTC by Report Bug Copy Issue Report `$app ?: \Illuminate\Cont...ontainer::getInstance()` is of type `object<Illuminate\Container\Container>`, but the property `$app` was declared to be of type `object<Illuminate\Foundation\Application>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
25			}
26
27
28			/**
29			* Create Laravel driver
30			*
31			* @return \Humweb\Sociable\Auth\LaravelDriver
32			*/
33			protected function createLaravelDriver()
34			{
35			return new LaravelDriver($this->app);
36			}
37
38
39			/**
40			* @return \Humweb\Sociable\Auth\SentinelDriver
41			*/
42			protected function createSentinelDriver()
43			{
44			return new SentinelDriver($this->app);
45			}
46
47
48			/**
49			* Get the default driver name.
50			*
51			* @return string
52			*/
53			public function getDefaultDriver()
54			{
55			return $this->app['config']->get('social.auth_provider', 'laravel');
56			}
57			}

humweb / sociable

GitHub Access Token became invalid

Push — master ( 3f2f54...ead273 )

Manager::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like