humbug / php-scoper

src/PhpParser/Node/NameFactory.php

<?php

/*
 * This file is part of the humbug/php-scoper package.
 *
 * Copyright (c) 2017 Théo FIDRY <theo.fidry@gmail.com>,
 *                    Pádraic Brady <padraic.brady@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Humbug\PhpScoper\PhpParser\Node;

use InvalidArgumentException;
use PhpParser\Node\Name;

final class NameFactory
{
    private function __construct()
    {
    }

    /**
     * @param string|string[]|Name|null $name1
     * @param string|string[]|Name|null $name2
     */
    public static function concat($name1, $name2, array $attributes = []): Name
    {
        if (null === $name1 && null === $name2) {
            throw new InvalidArgumentException('Expected one of the names to not be null');
        }

        /** @var Name $fqName */
        return Name::concat($name1, $name2, $attributes);

The expression return PhpParser\Node\Name::concat($name1, $name2, $attributes) could return the type null which is incompatible with the type-hinted return PhpParser\Node\Name. Consider adding an additional type-check to rule them out.

    }
}