Completed
Push — master ( dcddf7...d2fb4d )
by Théo
05:16 queued 03:22
created

ScopeNewStmtNodeVisitor   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 62
Duplicated Lines 37.1 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 0
Metric Value
dl 23
loc 62
rs 10
c 0
b 0
f 0
wmc 10
lcom 1
cbo 5

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 11 11 1
D enterNode() 11 39 9

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the humbug/php-scoper package.
7
 *
8
 * Copyright (c) 2017 Théo FIDRY <[email protected]>,
9
 *                    Pádraic Brady <[email protected]>
10
 *
11
 * For the full copyright and license information, please view the LICENSE
12
 * file that was distributed with this source code.
13
 */
14
15
namespace Humbug\PhpScoper\NodeVisitor\NewStmt;
16
17
use Humbug\PhpScoper\NodeVisitor\NamespaceStmtCollection;
18
use Humbug\PhpScoper\NodeVisitor\UseStmtCollection;
19
use PhpParser\Node;
20
use PhpParser\Node\Expr\New_;
21
use PhpParser\Node\Name;
22
use PhpParser\Node\Name\FullyQualified;
23
use PhpParser\NodeVisitorAbstract;
24
25
final class ScopeNewStmtNodeVisitor extends NodeVisitorAbstract
26
{
27
    private $prefix;
28
    private $namespaceStatements;
29
    private $useStatements;
30
    private $whitelist;
31
32 View Code Duplication
    public function __construct(
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
33
        string $prefix,
34
        NamespaceStmtCollection $namespaceStatements,
35
        UseStmtCollection $useStatements,
36
        array $whitelist
37
    ) {
38
        $this->prefix = $prefix;
39
        $this->namespaceStatements = $namespaceStatements;
40
        $this->useStatements = $useStatements;
41
        $this->whitelist = $whitelist;
42
    }
43
44
    /**
45
     * @inheritdoc
46
     */
47
    public function enterNode(Node $node): Node
48
    {
49
        if (false === ($node instanceof Name) || false === $node->hasAttribute('parent') || 1 === count($node->parts)) {
50
            return $node;
51
        }
52
53
        $parentNode = $node->getAttribute('parent');
54
55
        if (false === ($parentNode instanceof New_)) {
56
            return $node;
57
        }
58
59
        if (1 === count($node->parts)) {
60
            //TODO
61
            $x = '';
0 ignored issues
show
Unused Code introduced by
$x is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
62
        }
63
64
        $useStatement = $this->useStatements->findStatementForName($node->getFirst());
65
66 View Code Duplication
        if (null === $useStatement) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
67
            if (0 === count($this->namespaceStatements)) {
68
                return $node;
69
            }
70
71
            $namespaceStatement = $this->namespaceStatements->getNamespaceName();
72
73
            $newNode = FullyQualified::concat($namespaceStatement, $node, $node->getAttributes());
74
        } else {
75
            $newNode = FullyQualified::concat($useStatement, $node->slice(1), $node->getAttributes());
76
        }
77
78
        $newNode->setAttribute('phpscoper_ignore', true);
79
80
        if (in_array((string) $newNode, $this->whitelist)) {
81
            return $newNode;
82
        }
83
84
        return $node;
85
    }
86
}
87