Humbug\PhpScoper\PhpParser\NodeVisitor\OriginalNameResolver

Complexity

Total Complexity

4

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getOriginalName()	0	7	2
A	__construct()	0	2	1
A	hasOriginalName()	0	3	1

<?php

declare(strict_types=1);

/*
 * This file is part of the humbug/php-scoper package.
 *
 * Copyright (c) 2017 Théo FIDRY <theo.fidry@gmail.com>,
 *                    Pádraic Brady <padraic.brady@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Humbug\PhpScoper\PhpParser\NodeVisitor;

use PhpParser\Node\Name;

// TODO: review those classes
final class OriginalNameResolver
{
    private const ORIGINAL_NAME_ATTRIBUTE = 'originalName';

    public static function hasOriginalName(Name $namespace): bool
    {
        return $namespace->hasAttribute(self::ORIGINAL_NAME_ATTRIBUTE);
    }

    public static function getOriginalName(Name $name): Name
    {
        if (!self::hasOriginalName($name)) {
            return $name;
        }

        return $name->getAttribute(self::ORIGINAL_NAME_ATTRIBUTE);

The expression return $name->getAttribute(self::ORIGINAL_NAME_ATTRIBUTE) could return the type null which is incompatible with the type-hinted return PhpParser\Node\Name. Consider adding an additional type-check to rule them out.

    }

    private function __construct()
    {
    }
}