Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | View Code Duplication | final class Sha256Strategy extends ShaStrategyAbstract |
|
|
|||
20 | { |
||
21 | /** |
||
22 | * Retrieve the current version available remotely. |
||
23 | * |
||
24 | * @param Updater $updater |
||
25 | * @return string|bool |
||
26 | */ |
||
27 | public function getCurrentRemoteVersion(Updater $updater) |
||
51 | |||
52 | /** |
||
53 | * Retrieve the current version of the local phar file. |
||
54 | * |
||
55 | * @param Updater $updater |
||
56 | * @return string |
||
57 | */ |
||
58 | public function getCurrentLocalVersion(Updater $updater) |
||
62 | } |
||
63 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.