humbug / box

requirement-checker/tests/AutoReview/MakefileTest.php

<?php

declare(strict_types=1);

/*
 * This file is part of the box project.
 *
 * (c) Kevin Herrera <kevin@herrera.io>
 *     Théo Fidry <theo.fidry@gmail.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace KevinGH\RequirementChecker\AutoReview;

use Fidry\Makefile\Rule;
use Fidry\Makefile\Test\BaseMakefileTestCase;
use PHPUnit\Framework\Attributes\CoversNothing;

/**
 * @internal
 */
#[CoversNothing]
final class MakefileTest extends BaseMakefileTestCase
{
    public const MAKEFILE_PATH = __DIR__.'/../../Makefile';

    protected static function getMakefilePath(): string
    {
        return self::MAKEFILE_PATH;
    }

    protected function getExpectedHelpOutput(): string
    {
        return <<<'EOF'
            Usage:
              make TARGET
            
            #
            # Commands
            #---------------------------------------------------------------------------
            
            check:	 	 Runs all checks
            clean: 	 	 Cleans all created artifacts
            dump:	 	 Dumps the requirement-checker
            autoreview:	 AutoReview checks
            cs:	 	 Fixes CS
            cs_lint: 	 Checks CS
            test:		 Runs all the tests

            EOF;
    }

    public function test_the_test_rule_contains_all_test_targets(): void
    {
        $testRule = self::getTestRule();
        $testTargets = self::getTestRules();

        // Sanity check
        self::assertGreaterThan(0, count($testRule->getPrerequisites()));

        self::assertEqualsCanonicalizing(
            $testRule->getPrerequisites(),
            array_map(
                static fn (Rule $rule) => $rule->getTarget(),
                $testTargets,
            ),
        );
    }

    private static function getTestRule(): Rule
    {
        return current(
            array_filter(
                self::getParsedRules(),
                static fn (Rule $rule) => 'test' === $rule->getTarget() && !$rule->isComment() && !$rule->isPhony(),
            ),
        );
    }

    /**
     * @return Rule
     */
    private static function getTestRules(): array
    {
        return array_values(

The expression return array_values(array_filter(self::getParsedRules(), function(...) { /* ... */ })) returns the type array which is incompatible with the documented return type Fidry\Makefile\Rule.

            array_filter(
                self::getParsedRules(),
                static fn (Rule $rule) => str_starts_with($rule->getTarget(), 'test_') && !$rule->isComment() && !$rule->isPhony(),
            ),
        );
    }
}