DummyFileExtensionCompactor::supports() - Code Metrics - Inspection of "Refactor & Cleanup" - humbug/box - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#22)

by Théo

created 2018-01-20 00:13 UTC

DummyFileExtensionCompactor::supports() A

↳ Parent: DummyFileExtensionCompactor

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * This file is part of the box project.
 *
 * (c) Kevin Herrera <[email protected]>
 *     Théo Fidry <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace KevinGH\Box\Compactor;

use KevinGH\Box\NotCallable;

class DummyFileExtensionCompactor extends FileExtensionCompactor
{
    use NotCallable;

    /**
     * {@inheritdoc}
     */
    protected function compactContent(string $contents): string
    {
        $this->__call(__METHOD__, func_get_args());
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    /**
     * {@inheritdoc}
     */
    protected function supports(string $file): bool
    {
        $this->__call(__METHOD__, func_get_args());
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the box project.
7			*
8			* (c) Kevin Herrera <[email protected]>
9			* Théo Fidry <[email protected]>
10			*
11			* This source file is subject to the MIT license that is bundled
12			* with this source code in the file LICENSE.
13			*/
14
15			namespace KevinGH\Box\Compactor;
16
17			use KevinGH\Box\NotCallable;
18
19			class DummyFileExtensionCompactor extends FileExtensionCompactor
20			{
21			use NotCallable;
22
23			/**
24			* {@inheritdoc}
25			*/
26			protected function compactContent(string $contents): string
27			{
28			$this->__call(__METHOD__, func_get_args());
			1 ignored issue – show Bug Best Practice introduced 2017-12-03 15:47 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			protected function supports(string $file): bool
35			{
36			$this->__call(__METHOD__, func_get_args());
			1 ignored issue – show Bug Best Practice introduced 2018-01-19 23:59 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
37			}
38			}
39

humbug / box

Pull Request — master (#22)

DummyFileExtensionCompactor::supports() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like