RequirementCollectionTest::test_it_can_have_and_evaluate_requirements()

Complexity

Conditions	2
Paths	2

Size

Total Lines	48
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function test_it_can_have_and_evaluate_requirements(): void
    {
        $requirements = new RequirementCollection();

        $reqs = [
            $requirementA = new Requirement(
                'return true;',
                'req tA',
                'req hA'
            ),
            $requirementB = new Requirement(
                'return true;',
                'req tB',
                'req hB'
            ),
        ];

        foreach ($reqs as $requirement) {
            $requirements->add($requirement);
        }

        $this->assertSame($reqs, iterator_to_array($requirements));
        $this->assertSame($reqs, $requirements->getRequirements());
        $this->assertCount(2, $requirements);
        $this->assertTrue($requirements->evaluateRequirements());

        $requirements->addRequirement(
            'return false;',
            'req tC',
            'req hC'
        );

        $this->assertCount(3, $requirements);
        $this->assertFalse($requirements->evaluateRequirements());

        $retrievedRequirements = $requirements->getRequirements();

        $this->assertSame($retrievedRequirements, iterator_to_array($requirements));

        $this->assertSame($requirementA, $retrievedRequirements[0]);
        $this->assertSame($requirementB, $retrievedRequirements[1]);

        $requirementC = $retrievedRequirements[2];

        $this->assertSame('return false;', $requirementC->getIsFullfilledChecker());
        $this->assertTrue($requirement->isFulfilled());

The variable $requirement seems to be defined by a foreach iteration on line 52. Are you sure the iterator is never empty, otherwise this variable is not defined?

        $this->assertSame('req tC', $requirementC->getTestMessage());
        $this->assertSame('req hC', $requirementC->getHelpText());
    }