Passed
Pull Request — master (#22)
by Théo
02:11
created

DummyBufferedHash   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 19
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
wmc 3
dl 0
loc 19
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 2 1
A getPublicBufferedData() 0 3 1
A verify() 0 2 1
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the box project.
7
 *
8
 * (c) Kevin Herrera <[email protected]>
9
 *     Théo Fidry <[email protected]>
10
 *
11
 * This source file is subject to the MIT license that is bundled
12
 * with this source code in the file LICENSE.
13
 */
14
15
namespace KevinGH\Box\Verifier;
16
17
final class DummyBufferedHash extends BufferedHash
18
{
19
    /**
20
     * {@inheritdoc}
21
     */
22
    public function __construct(string $algorithm, string $path)
23
    {
24
    }
25
26
    /**
27
     * {@inheritdoc}
28
     */
29
    public function verify(string $signature): bool
30
    {
31
    }
1 ignored issue
show
Bug Best Practice introduced by
In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example:

interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
Loading history...
32
33
    public function getPublicBufferedData(): string
34
    {
35
        return $this->getBufferedData();
36
    }
37
}
38