KevinGH\Box\Console\Command\Extract::executeCommand()

Complexity

Conditions	6
Paths	33

Size

Total Lines	62
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function executeCommand(IO $io): int
    {
        $input = $io->getInput();

        $file = realpath($input->getArgument(self::PHAR_ARG));

It seems like $input->getArgument(self::PHAR_ARG) can also be of type string[]; however, parameter $path of realpath() does only seem to accept string, maybe add an additional type check?

        if (false === $file) {
            $io->error(
                sprintf(
                    'The file "%s" could not be found.',
                    $input->getArgument(self::PHAR_ARG)

It seems like $input->getArgument(self::PHAR_ARG) can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

                )
            );

            return 1;
        }

        $tmpFile = create_temporary_phar($file);

        try {
            $box = Box::create($tmpFile);
        } catch (Throwable $throwable) {
            if ($io->isDebug()) {
                throw new ConsoleRuntimeException(
                    'The given file is not a valid PHAR',
                    0,
                    $throwable
                );
            }

            $io->error('The given file is not a valid PHAR');

            return 1;
        }

        $restoreLimit = bump_open_file_descriptor_limit($box, $io);

        $outputDir = $input->getArgument(self::OUTPUT_ARG);

        try {
            remove($outputDir);

            foreach ($box->getPhar() as $pharFile) {
                /* @var PharFileInfo $pharFile */
                dump_file(
                    $outputDir.'/'.$pharFile->getFilename(),

Are you sure $outputDir of type null|string|string[] can be used in concatenation?

                    (string) $pharFile->getContent()
                );
            }
        } catch (RuntimeException $exception) {
            $io->error($exception->getMessage());

            return 1;
        } finally {
            $restoreLimit();

            remove($tmpFile);
        }

        $io->success('');

        return 0;
    }