E2EMakefileTest::getExpectedHelpOutput() - Code Metrics - humbug/box - Measure and Improve Code Quality continuously with Scrutinizer

E2EMakefileTest::getExpectedHelpOutput() A
last analyzed 2024-02-05 09:28 UTC

↳ Parent: E2EMakefileTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the box project.
 *
 * (c) Kevin Herrera <[email protected]>
 *     Théo Fidry <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace KevinGH\RequirementChecker\AutoReview;

use Fidry\Makefile\Rule;
use Fidry\Makefile\Test\BaseMakefileTestCase;
use PHPUnit\Framework\Attributes\CoversNothing;

/**
 * @internal
 */
#[CoversNothing]
final class E2EMakefileTest extends BaseMakefileTestCase
{
    public const MAKEFILE_PATH = __DIR__.'/../../Makefile.e2e';

    protected static function getMakefilePath(): string
    {
        return self::MAKEFILE_PATH;
    }

    protected function getExpectedHelpOutput(): string
    {
        self::markTestSkipped('There is no help command.');
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    public function test_the_e2e_target_must_contain_all_the_e2e_targets(): void
    {
        $e2eRule = MakefileE2ECollector::getE2ERule();
        $e2eTestTargets = self::getE2ETestRules();

        $e2eRulePrerequisites = $e2eRule->getPrerequisites();
        array_shift($e2eRulePrerequisites);   // Remove docker-images

        // Sanity check
        self::assertGreaterThan(0, count($e2eRule->getPrerequisites()));

        self::assertEqualsCanonicalizing(
            $e2eRulePrerequisites,
            array_map(
                static fn (Rule $rule) => $rule->getTarget(),
                $e2eTestTargets,
            ),
        );
    }

    /**
     * @return Rule
     */
    private static function getE2ETestRules(): array
    {
        return array_values(

            array_filter(
                self::getParsedRules(),
                static fn (Rule $rule) => str_starts_with($rule->getTarget(), '_test_e2e_') && !$rule->isComment() && !$rule->isPhony(),
            ),
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the box project.
7			*
8			* (c) Kevin Herrera <[email protected]>
9			* Théo Fidry <[email protected]>
10			*
11			* This source file is subject to the MIT license that is bundled
12			* with this source code in the file LICENSE.
13			*/
14
15			namespace KevinGH\RequirementChecker\AutoReview;
16
17			use Fidry\Makefile\Rule;
18			use Fidry\Makefile\Test\BaseMakefileTestCase;
19			use PHPUnit\Framework\Attributes\CoversNothing;
20
21			/**
22			* @internal
23			*/
24			#[CoversNothing]
25			final class E2EMakefileTest extends BaseMakefileTestCase
26			{
27			public const MAKEFILE_PATH = __DIR__.'/../../Makefile.e2e';
28
29			protected static function getMakefilePath(): string
30			{
31			return self::MAKEFILE_PATH;
32			}
33
34			protected function getExpectedHelpOutput(): string
35			{
36			self::markTestSkipped('There is no help command.');
			0 ignored issues – show Bug Best Practice introduced 2024-02-05 09:28 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
37			}
38
39			public function test_the_e2e_target_must_contain_all_the_e2e_targets(): void
40			{
41			$e2eRule = MakefileE2ECollector::getE2ERule();
42			$e2eTestTargets = self::getE2ETestRules();
43
44			$e2eRulePrerequisites = $e2eRule->getPrerequisites();
45			array_shift($e2eRulePrerequisites); // Remove docker-images
46
47			// Sanity check
48			self::assertGreaterThan(0, count($e2eRule->getPrerequisites()));
49
50			self::assertEqualsCanonicalizing(
51			$e2eRulePrerequisites,
52			array_map(
53			static fn (Rule $rule) => $rule->getTarget(),
54			$e2eTestTargets,
55			),
56			);
57			}
58
59			/**
60			* @return Rule
61			*/
62			private static function getE2ETestRules(): array
63			{
64			return array_values(
			0 ignored issues – show Bug Best Practice introduced 2024-02-05 09:28 UTC by Report Bug Copy Issue Report The expression `return array_values(arra...on(...) { /* ... */ }))` returns the type `array` which is incompatible with the documented return type `Fidry\Makefile\Rule`. Loading history...
65			array_filter(
66			self::getParsedRules(),
67			static fn (Rule $rule) => str_starts_with($rule->getTarget(), '_test_e2e_') && !$rule->isComment() && !$rule->isPhony(),
68			),
69			);
70			}
71			}
72

humbug / box

E2EMakefileTest::getExpectedHelpOutput() A last analyzed 2024-02-05 09:28 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

E2EMakefileTest::getExpectedHelpOutput() A
last analyzed 2024-02-05 09:28 UTC