Issues in class-services.php (master) - Issues in master - humanmade/backupwordpress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (217)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/class-services.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace HM\BackUpWordPress;

/**
 * A singleton to handle the registering, de-registering
 * and storage of services
 */
class Services {

	/**
	 * Store the current instance
	 *
	 * @access private
	 * @var object Services
	 * @static
	 */
	private static $instance;

	/**
	 * The array of services
	 *
	 * Should be of the format array( __FILE__ => __CLASS__ );
	 *
	 * @access private
	 * @var  array
	 * @static
	 */
	private $services = array();


	/**
	 * The current schedule object
	 *
	 * @access private
	 * @var object Scheduled_Backup
	 */
	private $schedule;


	/**
	 * Get the current instance
	 *
	 * @static
	 */
	public static function instance() {

		if ( ! isset( self::$instance ) ) {
			self::$instance = new Services;
		}

		return self::$instance;

	}

	/**
	 * Get the array of registered services
	 *
	 * @param Scheduled_Backup $schedule

	 * @return Service[]
	 */
	public static function get_services( Scheduled_Backup $schedule = null ) {

		if ( is_null( $schedule ) ) {
			return self::instance()->services;
		}

		self::instance()->schedule = $schedule;

		return array_map( array( self::instance(), 'instantiate' ), self::instance()->services );

	}

	/**
	 * Register a new service
	 *
	 * @param $filepath
	 * @param $classname
	 * @return \WP_Error|boolean
	 */
	public static function register( $filepath, $classname ) {
		if ( ! file_exists( $filepath ) ) {
			return new \WP_Error( 'hmbkp_invalid_path_error', sprintf( __( 'Argument 1 for %s must be a valid filepath', 'backupwordpress' ), __METHOD__ ) );
		}

		self::instance()->services[ $filepath ] = $classname;

		return true;
	}

	/**
	 * De-register an existing service
	 * @param string $filepath
	 * @return \WP_Error|boolean
	 */
	public static function unregister( $filepath ) {

		if ( ! isset( self::instance()->services[ $filepath ] ) ) {
			return new \WP_Error( 'hmbkp_unrecognized_service_error', sprintf( __( 'Argument 1 for %s must be a registered service', 'backupwordpress' ), __METHOD__ ) );
		}

		unset( self::instance()->services[ $filepath ] );

		return true;
	}

	/**
	 * Instantiate the individual service classes
	 *
	 * @param string $classname
	 *
	 * @return array An array of instantiated classes

	 */
	private static function instantiate( $classname ) {


		if ( ! class_exists( $classname ) ) {
			return new \WP_Error( 'hmbkp_invalid_type_error', sprintf( __( 'Argument 1 for %s must be a valid class', 'backupwordpress' ), __METHOD__ ) );
		}

		/**
		 * @var Service
		 */
		$class = new $classname( self::instance()->schedule );

		return $class;

	}
}


1		<?php
2
3		namespace HM\BackUpWordPress;
4
5		/**
6		* A singleton to handle the registering, de-registering
7		* and storage of services
8		*/
9		class Services {
10
11		/**
12		* Store the current instance
13		*
14		* @access private
15		* @var object Services
16		* @static
17		*/
18		private static $instance;
19
20		/**
21		* The array of services
22		*
23		* Should be of the format array( __FILE__ => __CLASS__ );
24		*
25		* @access private
26		* @var array
27		* @static
28		*/
29		private $services = array();
		0 ignored issues – show Unused Code introduced 2015-11-21 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$services` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
30
31		/**
32		* The current schedule object
33		*
34		* @access private
35		* @var object Scheduled_Backup
36		*/
37		private $schedule;
		0 ignored issues – show Unused Code introduced 2015-11-21 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$schedule` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
38
39		/**
40		* Get the current instance
41		*
42		* @static
43		*/
44		public static function instance() {
45
46		if ( ! isset( self::$instance ) ) {
47		self::$instance = new Services;
48		}
49
50		return self::$instance;
51
52		}
53
54		/**
55		* Get the array of registered services
56		*
57		* @param Scheduled_Backup $schedule
		0 ignored issues – show Documentation introduced 2015-11-21 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$schedule` not be `null\|Scheduled_Backup`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
58		* @return Service[]
59		*/
60		public static function get_services( Scheduled_Backup $schedule = null ) {
61
62		if ( is_null( $schedule ) ) {
63		return self::instance()->services;
64		}
65
66		self::instance()->schedule = $schedule;
67
68		return array_map( array( self::instance(), 'instantiate' ), self::instance()->services );
69
70		}
71
72		/**
73		* Register a new service
74		*
75		* @param $filepath
76		* @param $classname
77		* @return \WP_Error\|boolean
78		*/
79	View Code Duplication	public static function register( $filepath, $classname ) {
80		if ( ! file_exists( $filepath ) ) {
81		return new \WP_Error( 'hmbkp_invalid_path_error', sprintf( __( 'Argument 1 for %s must be a valid filepath', 'backupwordpress' ), __METHOD__ ) );
82		}
83
84		self::instance()->services[ $filepath ] = $classname;
85
86		return true;
87		}
88
89		/**
90		* De-register an existing service
91		* @param string $filepath
92		* @return \WP_Error\|boolean
93		*/
94	View Code Duplication	public static function unregister( $filepath ) {
95
96		if ( ! isset( self::instance()->services[ $filepath ] ) ) {
97		return new \WP_Error( 'hmbkp_unrecognized_service_error', sprintf( __( 'Argument 1 for %s must be a registered service', 'backupwordpress' ), __METHOD__ ) );
98		}
99
100		unset( self::instance()->services[ $filepath ] );
101
102		return true;
103		}
104
105		/**
106		* Instantiate the individual service classes
107		*
108		* @param string $classname
109		*
110		* @return array An array of instantiated classes
		0 ignored issues – show Documentation introduced 2015-11-21 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `object`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
111		*/
112	View Code Duplication	private static function instantiate( $classname ) {
		0 ignored issues – show Unused Code introduced 2015-11-21 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method is not used, and could be removed. Loading history...
113
114		if ( ! class_exists( $classname ) ) {
115		return new \WP_Error( 'hmbkp_invalid_type_error', sprintf( __( 'Argument 1 for %s must be a valid class', 'backupwordpress' ), __METHOD__ ) );
116		}
117
118		/**
119		* @var Service
120		*/
121		$class = new $classname( self::instance()->schedule );
122
123		return $class;
124
125		}
126		}
127

GitHub Access Token became invalid

Issues (217)

Security Analysis no vulnerabilities found

classes/class-services.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

humanmade / backupwordpress

GitHub Access Token became invalid

Issues (217)

Security Analysis no vulnerabilities found

classes/class-services.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like