humanmade / backupwordpress

classes/backup/class-backup-engine-file.php

<?php

namespace HM\BackUpWordPress;

use Symfony\Component\Finder\Finder as Finder;

/**
 * The File Backup Engine type
 *
 * All File Backup Engine implementations should extend this class
 */
abstract class File_Backup_Engine extends Backup_Engine {

	/**
	 * The array of excludes rules
	 *
	 * @var array
	 */
	protected $excludes;

	/**
	 * Set the default backup filename.
	 */
	public function __construct() {

		parent::__construct();

		$this->set_backup_filename( implode( '-', array(
			str_ireplace( array( 'http://', 'https://', 'www' ), '', home_url() ),
			'backup',
			current_time( 'Y-m-d-H-i-s' ),
		) ) . '.zip' );

		$this->excludes = new Excludes;

It seems like new \HM\BackUpWordPress\Excludes() of type object<HM\BackUpWordPress\Excludes> is incompatible with the declared type array of property $excludes.

	}

	/**
	 * Set the excludes rules for the backup.
	 *
	 * @param array $excludes The exclude rules.

Should the type for parameter $excludes not be Excludes?

	 */
	public function set_excludes( Excludes $excludes ) {
		$this->excludes = $excludes;

It seems like $excludes of type object<HM\BackUpWordPress\Excludes> is incompatible with the declared type array of property $excludes.

	}

	/**
	 * Returns a Finder instance for the files that will be included in the
	 * backup.
	 *
	 * By default we ignore unreadable files and directories as well as, common
	 * version control folders / files, "Dot" files and anything matching the
	 * exclude rules.
	 *
	 * @uses Finder
	 * @return Finder The Finder iterator of all files to be included
	 */
	public function get_files() {

		$finder = new Finder();

		$finder->followLinks( true );

The call to Finder::followLinks() has too many arguments starting with true.

		$finder->ignoreDotFiles( false );
		$finder->ignoreVCS( true );
		$finder->ignoreUnreadableDirs( true );

		// Skip unreadable files too
		$finder->filter(
			function ( \SplFileInfo $file ) {
				if ( ! $file->isReadable() ) {
					return false;
				}
			}
		);

		// Finder expects exclude rules to be in a regex format
		$exclude_rules = $this->excludes->get_excludes_for_regex();

The method get_excludes_for_regex cannot be called on $this->excludes (of type array).

		// Skips folders/files that match default exclude patterns
		foreach ( $exclude_rules as $exclude ) {
			$finder->notPath( $exclude );
		}

		return $finder->in( Path::get_root() );

The expression $finder->in(\HM\BackUpWordPress\Path::get_root()); of type Symfony\Component\Finder\Finder|Symfony\Component\Finder\SplFileInfo[] adds the type Symfony\Component\Finder\SplFileInfo[] to the return on line 84 which is incompatible with the return type documented by HM\BackUpWordPress\File_Backup_Engine::get_files of type Symfony\Component\Finder\Finder.

	}

	/**
	 * Verify that the file backup completed successfully.
	 *
	 * This should be called from backup method of any final file backup engine
	 * implementations.
	 *
	 * @return bool Whether the backup completed successfully.
	 */
	public function verify_backup() {

		// If there are errors delete the backup file.
		if ( $this->get_errors( get_called_class() ) && file_exists( $this->get_backup_filepath() ) ) {
			unlink( $this->get_backup_filepath() );
		}

		// If the backup doesn't exist then we must have failed.
		if ( ! file_exists( $this->get_backup_filepath() ) ) {
			return false;
		}

		return true;

	}
}