Issues in schedule-form.php (master) - Issues in master - humanmade/backupwordpress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (217)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

admin/schedule-form.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace HM\BackUpWordPress;

?>

<h3><?php esc_html_e( 'Settings', 'backupwordpress' ); ?></h3>

<?php $hmbkp_form_errors = get_settings_errors(); ?>

<?php if ( ! empty( $hmbkp_form_errors ) ) { ?>

	<div id="hmbkp-warning" class="error settings-error">

		<?php foreach ( $hmbkp_form_errors as $error ) { ?>
			<p><strong><?php echo wp_kses_data( $error ); ?></strong></p>
		<?php } ?>

	</div>

<?php }

// We can clear them now we've displayed them
clear_settings_errors();

?>

<form method="post" action="<?php echo esc_url( admin_url( 'admin-post.php' ) ); ?>">

	<input type="hidden" name="hmbkp_schedule_id" value="<?php echo esc_attr( $schedule->get_id() ); ?>" />
	<input type="hidden" name="action" value="hmbkp_edit_schedule_submit" />

	<?php wp_nonce_field( 'hmbkp-edit-schedule', 'hmbkp-edit-schedule-nonce' ); ?>

	<table class="form-table">

		<tbody>

			<tr valign="top">

				<th scope="row">
					<label for="hmbkp_schedule_type"><?php _e( 'Backup', 'backupwordpress' ); ?></label>
				</th>

				<td>

					<select name="hmbkp_schedule_type" id="hmbkp_schedule_type">

						<option<?php selected( $schedule->get_type(), 'complete' ); ?> value="complete"><?php _e( 'Both Database &amp; files', 'backupwordpress' ); ?></option>

						<option<?php selected( $schedule->get_type(), 'file' ); ?> value="file"><?php _e( 'Files only', 'backupwordpress' ); ?></option>

						<option<?php selected( $schedule->get_type(), 'database' ); ?> value="database"><?php _e( 'Database only', 'backupwordpress' ); ?></option>

					</select>

				</td>

			</tr>

			<tr>

				<th scope="row">
					<label for="hmbkp_schedule_recurrence_type"><?php _e( 'Schedule', 'backupwordpress' ); ?></label>
				</th>

				<td>

					<select name="hmbkp_schedule_recurrence[hmbkp_type]" id="hmbkp_schedule_recurrence_type">

						<option value="manually"><?php _e( 'Manual Only', 'backupwordpress' ); ?></option>

						<?php foreach ( get_cron_schedules() as $cron_schedule => $cron_details ) : ?>

								<option <?php selected( $schedule->get_reoccurrence(), $cron_schedule ); ?> value="<?php echo esc_attr( $cron_schedule ); ?>">

									<?php esc_html_e( $cron_details['display'], 'backupwordpress' ); ?>

								</option>

						<?php endforeach; ?>

					</select>

				</td>

			</tr>

			<?php if ( ! $start_time = $schedule->get_schedule_start_time( false ) ) :
				$start_time = time();
			endif; ?>

			<?php $start_date_array = date_parse( date_i18n( get_option( 'date_format' ) . ' ' . get_option( 'time_format' ), $start_time ) ); ?>

			<tr id="start-day" class="recurring-setting">

				<th scope="row">
					<label for="hmbkp_schedule_start_day_of_week"><?php _e( 'Start Day', 'backupwordpress' ); ?></label>
				</th>

				<td>

					<select id="hmbkp_schedule_start_day_of_week" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_day_of_week]">

						<?php $weekdays = array(
							'monday'    => __( 'Monday',    'backupwordpress' ),
							'tuesday'   => __( 'Tuesday',   'backupwordpress' ),
							'wednesday' => __( 'Wednesday', 'backupwordpress' ),
							'thursday'  => __( 'Thursday',  'backupwordpress' ),
							'friday'    => __( 'Friday',    'backupwordpress' ),
							'saturday'  => __( 'Saturday',  'backupwordpress' ),
							'sunday'    => __( 'Sunday',    'backupwordpress' ),
						);

						foreach ( $weekdays as $key => $day ) : ?>

							<option value="<?php echo esc_attr( $key ) ?>" <?php selected( strtolower( date_i18n( 'l', $start_time ) ), $key ); ?>><?php echo esc_html( $day ); ?></option>

						<?php endforeach; ?>

					</select>

				</td>

			</tr>

			<tr id="start-date" class="recurring-setting">

				<th scope="row">
					<label for="hmbkp_schedule_start_day_of_month"><?php _e( 'Start Day of Month', 'backupwordpress' ); ?></label>
				</th>

				<td>
					<input type="number" min="0" max="31" step="1" id="hmbkp_schedule_start_day_of_month" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_day_of_month]" value="<?php echo esc_attr( $start_date_array['day'] ); ?>">
				</td>

			</tr>

			<tr id="schedule-start" class="recurring-setting">

				<th scope="row">
					<label for="hmbkp_schedule_start_hours"><?php _e( 'Start Time', 'backupwordpress' ); ?></label>
				</th>

				<td>

					<span class="field-group">

						<label for="hmbkp_schedule_start_hours"><input type="number" min="0" max="23" step="1" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_hours]" id="hmbkp_schedule_start_hours" value="<?php echo esc_attr( $start_date_array['hour'] ); ?>">

						<?php _e( 'Hours', 'backupwordpress' ); ?></label>

						<label for="hmbkp_schedule_start_minutes"><input type="number" min="0" max="59" step="1" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_minutes]" id="hmbkp_schedule_start_minutes" value="<?php echo esc_attr( $start_date_array['minute'] ); ?>">

						<?php _e( 'Minutes', 'backupwordpress' ); ?></label>

					</span>

					<p class="description">
						<?php esc_html_e( '24-hour format.', 'backupwordpress' ); ?>
						<span class="twice-js <?php if ( $schedule->get_reoccurrence() !== 'fortnightly' ) { ?> hidden<?php } ?>"><?php _e( 'The second backup will run 12 hours after the first.', 'backupwordpress' ); ?><span>
					</p>

				</td>

			</tr>

			<tr>

				<th scope="row">
					<label for="hmbkp_schedule_max_backups"><?php _e( 'Number of backups to store on this server', 'backupwordpress' ); ?></label>
				</th>

				<td>

					<input type="number" id="hmbkp_schedule_max_backups" name="hmbkp_schedule_max_backups" min="1" step="1" value="<?php echo esc_attr( $schedule->get_max_backups() ); ?>" />

					<p class="description">

						<?php printf( __( 'Past this limit older backups will be deleted automatically.', 'backupwordpress' ) ); ?>

						<?php

						$site_size = new Site_Size;

						if ( $site_size->is_site_size_cached() ) :
							printf( __( 'This schedule will store a maximum of %s of backups.', 'backupwordpress' ), '<code>' . esc_html( size_format( $site_size->get_site_size( $schedule->get_type(), $schedule->get_excludes() ) * $schedule->get_max_backups() ) ) . '</code>' );

						endif; ?>

					</p>

				</td>

			</tr>

			<?php foreach ( Services::get_services( $schedule ) as $service ) :
				$service->field();
			endforeach; ?>

		</tbody>

	</table>

	<?php submit_button( __( 'Done', 'backupwordpress' ) ); ?>

</form>


GitHub Access Token became invalid

Issues (217)

Security Analysis no vulnerabilities found

admin/schedule-form.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace HM\BackUpWordPress;
4
5			?>
6
7			<h3><?php esc_html_e( 'Settings', 'backupwordpress' ); ?></h3>
8
9			<?php $hmbkp_form_errors = get_settings_errors(); ?>
10
11			<?php if ( ! empty( $hmbkp_form_errors ) ) { ?>
12
13			<div id="hmbkp-warning" class="error settings-error">
14
15			<?php foreach ( $hmbkp_form_errors as $error ) { ?>
16			<p><strong><?php echo wp_kses_data( $error ); ?></strong></p>
17			<?php } ?>
18
19			</div>
20
21			<?php }
22
23			// We can clear them now we've displayed them
24			clear_settings_errors();
25
26			?>
27
28			<form method="post" action="<?php echo esc_url( admin_url( 'admin-post.php' ) ); ?>">
29
30			<input type="hidden" name="hmbkp_schedule_id" value="<?php echo esc_attr( $schedule->get_id() ); ?>" />
31			<input type="hidden" name="action" value="hmbkp_edit_schedule_submit" />
32
33			<?php wp_nonce_field( 'hmbkp-edit-schedule', 'hmbkp-edit-schedule-nonce' ); ?>
34
35			<table class="form-table">
36
37			<tbody>
38
39			<tr valign="top">
40
41			<th scope="row">
42			<label for="hmbkp_schedule_type"><?php _e( 'Backup', 'backupwordpress' ); ?></label>
43			</th>
44
45			<td>
46
47			<select name="hmbkp_schedule_type" id="hmbkp_schedule_type">
48
49			<option<?php selected( $schedule->get_type(), 'complete' ); ?> value="complete"><?php _e( 'Both Database & files', 'backupwordpress' ); ?></option>
50
51			<option<?php selected( $schedule->get_type(), 'file' ); ?> value="file"><?php _e( 'Files only', 'backupwordpress' ); ?></option>
52
53			<option<?php selected( $schedule->get_type(), 'database' ); ?> value="database"><?php _e( 'Database only', 'backupwordpress' ); ?></option>
54
55			</select>
56
57			</td>
58
59			</tr>
60
61			<tr>
62
63			<th scope="row">
64			<label for="hmbkp_schedule_recurrence_type"><?php _e( 'Schedule', 'backupwordpress' ); ?></label>
65			</th>
66
67			<td>
68
69			<select name="hmbkp_schedule_recurrence[hmbkp_type]" id="hmbkp_schedule_recurrence_type">
70
71			<option value="manually"><?php _e( 'Manual Only', 'backupwordpress' ); ?></option>
72
73			<?php foreach ( get_cron_schedules() as $cron_schedule => $cron_details ) : ?>
74
75			<option <?php selected( $schedule->get_reoccurrence(), $cron_schedule ); ?> value="<?php echo esc_attr( $cron_schedule ); ?>">
76
77			<?php esc_html_e( $cron_details['display'], 'backupwordpress' ); ?>
78
79			</option>
80
81			<?php endforeach; ?>
82
83			</select>
84
85			</td>
86
87			</tr>
88
89			<?php if ( ! $start_time = $schedule->get_schedule_start_time( false ) ) :
90			$start_time = time();
91			endif; ?>
92
93			<?php $start_date_array = date_parse( date_i18n( get_option( 'date_format' ) . ' ' . get_option( 'time_format' ), $start_time ) ); ?>
94
95			<tr id="start-day" class="recurring-setting">
96
97			<th scope="row">
98			<label for="hmbkp_schedule_start_day_of_week"><?php _e( 'Start Day', 'backupwordpress' ); ?></label>
99			</th>
100
101			<td>
102
103			<select id="hmbkp_schedule_start_day_of_week" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_day_of_week]">
104
105			<?php $weekdays = array(
106			'monday' => __( 'Monday', 'backupwordpress' ),
107			'tuesday' => __( 'Tuesday', 'backupwordpress' ),
108			'wednesday' => __( 'Wednesday', 'backupwordpress' ),
109			'thursday' => __( 'Thursday', 'backupwordpress' ),
110			'friday' => __( 'Friday', 'backupwordpress' ),
111			'saturday' => __( 'Saturday', 'backupwordpress' ),
112			'sunday' => __( 'Sunday', 'backupwordpress' ),
113			);
114
115			foreach ( $weekdays as $key => $day ) : ?>
116
117			<option value="<?php echo esc_attr( $key ) ?>" <?php selected( strtolower( date_i18n( 'l', $start_time ) ), $key ); ?>><?php echo esc_html( $day ); ?></option>
118
119			<?php endforeach; ?>
120
121			</select>
122
123			</td>
124
125			</tr>
126
127			<tr id="start-date" class="recurring-setting">
128
129			<th scope="row">
130			<label for="hmbkp_schedule_start_day_of_month"><?php _e( 'Start Day of Month', 'backupwordpress' ); ?></label>
131			</th>
132
133			<td>
134			<input type="number" min="0" max="31" step="1" id="hmbkp_schedule_start_day_of_month" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_day_of_month]" value="<?php echo esc_attr( $start_date_array['day'] ); ?>">
135			</td>
136
137			</tr>
138
139			<tr id="schedule-start" class="recurring-setting">
140
141			<th scope="row">
142			<label for="hmbkp_schedule_start_hours"><?php _e( 'Start Time', 'backupwordpress' ); ?></label>
143			</th>
144
145			<td>
146
147			<span class="field-group">
148
149			<label for="hmbkp_schedule_start_hours"><input type="number" min="0" max="23" step="1" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_hours]" id="hmbkp_schedule_start_hours" value="<?php echo esc_attr( $start_date_array['hour'] ); ?>">
150
151			<?php _e( 'Hours', 'backupwordpress' ); ?></label>
152
153			<label for="hmbkp_schedule_start_minutes"><input type="number" min="0" max="59" step="1" name="hmbkp_schedule_recurrence[hmbkp_schedule_start_minutes]" id="hmbkp_schedule_start_minutes" value="<?php echo esc_attr( $start_date_array['minute'] ); ?>">
154
155			<?php _e( 'Minutes', 'backupwordpress' ); ?></label>
156
157			</span>
158
159			<p class="description">
160			<?php esc_html_e( '24-hour format.', 'backupwordpress' ); ?>
161			<span class="twice-js <?php if ( $schedule->get_reoccurrence() !== 'fortnightly' ) { ?> hidden<?php } ?>"><?php _e( 'The second backup will run 12 hours after the first.', 'backupwordpress' ); ?><span>
162			</p>
163
164			</td>
165
166			</tr>
167
168			<tr>
169
170			<th scope="row">
171			<label for="hmbkp_schedule_max_backups"><?php _e( 'Number of backups to store on this server', 'backupwordpress' ); ?></label>
172			</th>
173
174			<td>
175
176			<input type="number" id="hmbkp_schedule_max_backups" name="hmbkp_schedule_max_backups" min="1" step="1" value="<?php echo esc_attr( $schedule->get_max_backups() ); ?>" />
177
178			<p class="description">
179
180			<?php printf( __( 'Past this limit older backups will be deleted automatically.', 'backupwordpress' ) ); ?>
181
182			<?php
183
184			$site_size = new Site_Size;
185
186			if ( $site_size->is_site_size_cached() ) :
187			printf( __( 'This schedule will store a maximum of %s of backups.', 'backupwordpress' ), '<code>' . esc_html( size_format( $site_size->get_site_size( $schedule->get_type(), $schedule->get_excludes() ) * $schedule->get_max_backups() ) ) . '</code>' );
			0 ignored issues – show Unused Code introduced 2015-11-30 00:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Site_Size::get_site_size()` has too many arguments starting with `$schedule->get_type()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
188			endif; ?>
189
190			</p>
191
192			</td>
193
194			</tr>
195
196			<?php foreach ( Services::get_services( $schedule ) as $service ) :
197			$service->field();
198			endforeach; ?>
199
200			</tbody>
201
202			</table>
203
204			<?php submit_button( __( 'Done', 'backupwordpress' ) ); ?>
205
206			</form>
207

humanmade / backupwordpress

GitHub Access Token became invalid

Issues (217)

Security Analysis no vulnerabilities found

admin/schedule-form.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like