Complex classes like Path often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Path, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
11 | class Path { |
||
12 | |||
13 | /** |
||
14 | * The path to the directory that backup files are stored in |
||
15 | * |
||
16 | * @var string $this->path |
||
17 | */ |
||
18 | private $path; |
||
19 | |||
20 | /** |
||
21 | * The path to the directory that will be backed up |
||
22 | * |
||
23 | * @var string $this->root |
||
24 | */ |
||
25 | private $root; |
||
26 | |||
27 | /** |
||
28 | * The path to the directory that backup files are stored in |
||
29 | * |
||
30 | * @var string $this->path |
||
31 | */ |
||
32 | private $custom_path; |
||
33 | |||
34 | /** |
||
35 | * Contains the instantiated Path instance |
||
36 | * |
||
37 | * @var Path $this->instance |
||
38 | */ |
||
39 | private static $instance; |
||
40 | |||
41 | /** |
||
42 | * Protected constructor to prevent creating a new instance of the |
||
43 | * *Singleton* via the `new` operator from outside of this class. |
||
44 | */ |
||
45 | protected function __construct() {} |
||
46 | |||
47 | /** |
||
48 | * Private clone method to prevent cloning of the instance of the |
||
49 | * *Singleton* instance. |
||
50 | */ |
||
51 | private function __clone() {} |
||
52 | |||
53 | /** |
||
54 | * Private unserialize method to prevent unserializing of the *Singleton* |
||
55 | * instance. |
||
56 | */ |
||
57 | private function __wakeup() {} |
||
58 | |||
59 | /** |
||
60 | * Returns the *Singleton* instance of this class. |
||
61 | * |
||
62 | * @staticvar Path $instance The *Singleton* instances of this class. |
||
63 | * |
||
64 | * @return Path The *Singleton* instance. |
||
65 | */ |
||
66 | public static function get_instance() { |
||
67 | |||
68 | if ( ! ( self::$instance instanceof Path ) ) { |
||
69 | self::$instance = new Path(); |
||
70 | } |
||
71 | |||
72 | return self::$instance; |
||
73 | } |
||
74 | |||
75 | /** |
||
76 | * Convenience method for quickly grabbing the path |
||
77 | */ |
||
78 | public static function get_path() { |
||
81 | |||
82 | /** |
||
83 | * Convenience method for quickly grabbing the root |
||
84 | */ |
||
85 | public static function get_root() { |
||
88 | |||
89 | /** |
||
90 | * Calculate the path to the site "home" directory. |
||
91 | * |
||
92 | * The home directory is the path equivalent to the home_url. That is, |
||
93 | * the path to the true root of the website. In situations where WordPress is |
||
94 | * installed in a subdirectory the home path is different to ABSPATH |
||
95 | * |
||
96 | * @param string $site_path The site_path to use when calculating the home path, defaults to ABSPATH |
||
97 | */ |
||
98 | public static function get_home_path( $site_path = ABSPATH ) { |
||
133 | |||
134 | /** |
||
135 | * get the calculated path to the directory where backups will be stored |
||
136 | */ |
||
137 | private function get_calculated_path() { |
||
150 | |||
151 | /** |
||
152 | * Set the path directly, overriding the default |
||
153 | * |
||
154 | * @param $path |
||
155 | */ |
||
156 | public function set_path( $path ) { |
||
164 | |||
165 | /** |
||
166 | * get the calculated path to the directory that will be backed up |
||
167 | */ |
||
168 | private function get_calculated_root() { |
||
183 | |||
184 | /** |
||
185 | * Set the root path directly, overriding the default |
||
186 | * |
||
187 | * @param $root |
||
188 | */ |
||
189 | public function set_root( $root ) { |
||
192 | |||
193 | public function reset_path() { |
||
196 | |||
197 | /** |
||
198 | * Get the path to the default backup location in wp-content |
||
199 | */ |
||
200 | public function get_default_path() { |
||
203 | |||
204 | /** |
||
205 | * Get the path to the fallback backup location in uploads |
||
206 | */ |
||
207 | public function get_fallback_path() { |
||
214 | |||
215 | /** |
||
216 | * Get the path to the custom backup location if it's been set |
||
217 | */ |
||
218 | public function get_custom_path() { |
||
231 | |||
232 | /** |
||
233 | * Builds an array containing existing backups folders. |
||
234 | * |
||
235 | * @return array |
||
236 | */ |
||
237 | public function get_existing_paths() { |
||
256 | |||
257 | /** |
||
258 | * Returns the first existing path if there is one |
||
259 | * |
||
260 | * @return string Backup path if found empty string if not |
||
261 | */ |
||
262 | public function get_existing_path() { |
||
273 | |||
274 | /** |
||
275 | * Calculate the backup path and create the directory if it doesn't exist. |
||
276 | * |
||
277 | * Tries all possible locations and uses the first one possible |
||
278 | * |
||
279 | * @return |
||
280 | */ |
||
281 | public function calculate_path() { |
||
313 | |||
314 | /** |
||
315 | * Protect the directory that backups are stored in |
||
316 | * |
||
317 | * - Adds an index.html file in an attempt to disable directory browsing |
||
318 | * - Adds a .httaccess file to deny direct access if on Apache |
||
319 | * |
||
320 | * @param string $reset |
||
321 | */ |
||
322 | public function protect_path( $reset = 'no' ) { |
||
362 | |||
363 | /** |
||
364 | * If we have more than one path then move any existing backups to the current path and remove them |
||
365 | */ |
||
366 | public function merge_existing_paths() { |
||
377 | |||
378 | /** |
||
379 | * Move backup files from an existing directory and the new |
||
380 | * location |
||
381 | * |
||
382 | * @param string $path The path to move the backups from |
||
383 | */ |
||
384 | public function move_old_backups( $from ) { |
||
425 | |||
426 | /** |
||
427 | * Clean any temporary / incomplete backups from the backups directory |
||
428 | */ |
||
429 | public function cleanup() { |
||
447 | |||
448 | } |
||
449 | |||
457 |
Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a
@return
annotation as described here.