Extensions::fetch() - Code Metrics - Inspection of "Add the beginnings of a dedicated page for extensi..." - humanmade/backupwordpress - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#909)

by Paul

created 2016-03-07 13:09 UTC

Extensions::fetch() A

↳ Parent: Extensions

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	19
rs	9.4285
cc	2
eloc	9
nc	2
nop	2

<?php

namespace HM\BackUpWordPress;

class Extensions {

	private static $instance;

	function __construct( $root_url ) {


		$this->root_url  = $root_url;
class MyClass { }

$x = new MyClass();
$x->foo = true;

	}

	public static function get_instance() {


		if ( ! static::$instance ) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}

			$root_url = 'https://bwp.hmn.md/wp-json/wp/v2/';

			static::$instance = new static( $root_url );
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
		}

		return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
	}

	public function get_edd_data() {

		$response = $this->fetch( 'edd-downloads', 600 );

		if ( is_wp_error( $response ) || empty( $response['body'] ) ) {
			return false;
		}

		return json_decode( $response['body'] );

	}

	function fetch( $endpoint, $ttl = 10 ) {


		$request_url = $this->root_url . $endpoint;

		$cache_key = md5( $request_url );

		$cached = get_transient( 'bwp_' . $cache_key );

		if ( $cached ) {
			return $cached;
		}

		$response = wp_remote_get( $request_url );

		set_transient( 'bwp_' . $cache_key, $response, $ttl );

		return $response;

	}

}


1			<?php
2
3			namespace HM\BackUpWordPress;
4
5			class Extensions {
6
7			private static $instance;
8
9			function __construct( $root_url ) {
			0 ignored issues – show Best Practice introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
10
11			$this->root_url = $root_url;
			0 ignored issues – show Bug introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report The property `root_url` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
12
13			}
14
15			public static function get_instance() {
			0 ignored issues – show Documentation introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
16
17			if ( ! static::$instance ) {
			0 ignored issues – show Bug introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
18
19			$root_url = 'https://bwp.hmn.md/wp-json/wp/v2/';
20
21			static::$instance = new static( $root_url );
			0 ignored issues – show Bug introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
22			}
23
24			return static::$instance;
			0 ignored issues – show Bug introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
25			}
26
27			public function get_edd_data() {
28
29			$response = $this->fetch( 'edd-downloads', 600 );
30
31			if ( is_wp_error( $response ) \|\| empty( $response['body'] ) ) {
32			return false;
33			}
34
35			return json_decode( $response['body'] );
36
37			}
38
39			function fetch( $endpoint, $ttl = 10 ) {
			0 ignored issues – show Documentation introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Best Practice introduced 2016-02-29 16:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
40
41			$request_url = $this->root_url . $endpoint;
42
43			$cache_key = md5( $request_url );
44
45			$cached = get_transient( 'bwp_' . $cache_key );
46
47			if ( $cached ) {
48			return $cached;
49			}
50
51			$response = wp_remote_get( $request_url );
52
53			set_transient( 'bwp_' . $cache_key, $response, $ttl );
54
55			return $response;
56
57			}
58
59			}
60

humanmade / backupwordpress

GitHub Access Token became invalid

Pull Request — master (#909)

Extensions::fetch() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like