HM\BackUpWordPress\Services

Complexity

Total Complexity

11

Size/Duplication

Total Lines	122
Duplicated Lines	27.05 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	instance()	0	8	2
A	get_services()	0	11	2
A	get_available_services()	0	3	1
A	register()	9	9	2
A	unregister()	10	10	2
A	instantiate()	14	14	2

<?php

namespace HM\BackUpWordPress;

/**
 * A singleton to handle the registering, de-registering
 * and storage of services
 */
class Services {

	/**
	 * Store the current instance
	 *
	 * @access private
	 * @var object Services
	 * @static
	 */
	private static $instance;

	/**
	 * The array of services
	 *
	 * Should be of the format array( __FILE__ => __CLASS__ );
	 *
	 * @access private
	 * @var  array
	 * @static
	 */
	private $services = array();

The property $services is not used and could be removed.

	/**
	 * The current schedule object
	 *
	 * @access private
	 * @var object Scheduled_Backup
	 */
	private $schedule;

The property $schedule is not used and could be removed.

	/**
	 * Get the current instance
	 *
	 * @static
	 */
	public static function instance() {

		if ( ! isset( self::$instance ) )
			self::$instance = new Services;

		return self::$instance;

	}

	/**
	 * Get the array of registered services
	 *
	 * @param Scheduled_Backup $schedule

Should the type for parameter $schedule not be null|Scheduled_Backup?

	 * @return Service[]
	 */
	public static function get_services( Scheduled_Backup $schedule = null ) {

		if ( is_null( $schedule ) ) {
			return self::instance()->services;
		}

		self::instance()->schedule = $schedule;

		return array_map( array( self::instance(), 'instantiate' ), self::instance()->services );

	}

	public function get_available_services() {
		return $this->get_services();
	}

	/**
	 * Register a new service
	 *
	 * @param $filepath
	 * @param $classname
	 * @return bool|WP_Error

Should the return type not be \WP_Error|boolean?

	 */
	public static function register( $filepath, $classname ) {

This method seems to be duplicated in your project.

		if ( ! file_exists( $filepath ) ) {
			return new \WP_Error( 'hmbkp_invalid_path_error', sprintf( __( 'Argument 1 for %s must be a valid filepath', 'backupwordpress' ), __METHOD__ ) );
		}

		self::instance()->services[ $filepath ] = $classname;

		return true;
	}

	/**
	 * De-register an existing service
	 * @param string $filepath
	 * @return bool|WP_Error

Should the return type not be \WP_Error|boolean?

	 */
	public static function unregister( $filepath ) {

This method seems to be duplicated in your project.

		if ( ! isset( self::instance()->services[ $filepath ] ) ) {
			return new \WP_Error( 'hmbkp_unrecognized_service_error', sprintf( __( 'Argument 1 for %s must be a registered service', 'backupwordpress' ), __METHOD__ ) );
		}

		unset( self::instance()->services[ $filepath ] );

		return true;
	}

	/**
	 * Instantiate the individual service classes
	 *
	 * @param string $classname
	 *
	 * @return array An array of instantiated classes

Should the return type not be object?

	 */
	private static function instantiate( $classname ) {

This method is not used, and could be removed.

This method seems to be duplicated in your project.

		if ( ! class_exists( $classname ) ) {
			return new \WP_Error( 'hmbkp_invalid_type_error', sprintf( __( 'Argument 1 for %s must be a valid class', 'backupwordpress' ), __METHOD__ ) );
		}

		/**
		 * @var Service
		 */
		$class = new $classname( self::instance()->schedule );

		return $class;

	}

}