HMBKP_Services

Complexity

Total Complexity

5

Size/Duplication

Total Lines	79
Duplicated Lines	16.46 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	instance()	0	8	2
A	register()	0	4	1
A	instantiate()	13	13	2

<?php


/**
 * An abstract service class, individual services should
 * extend this class
 */
abstract class HMBKP_Service {}

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

/**
 * A singleton to handle the registering, de-registering
 * and storage of services
 */
class HMBKP_Services {

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	/**
	 * Store the current instance
	 *
	 * @access private
	 * @var object HMBKP_Services
	 * @static
	 */
	private static $instance;

	/**
	 * The array of services
	 *
	 * Should be of the format array( __FILE__ => __CLASS__ );
	 *
	 * @access private
	 * @var  array
	 * @static
	 */
	private $services = array();

The property $services is not used and could be removed.

	/**
	 * The current schedule object
	 *
	 * @access private
	 * @var object HMBKP_Scheduled_Backup
	 */
	private $schedule;

The property $schedule is not used and could be removed.

	/**
	 * Get the current instance
	 *
	 * @access public
	 * @static
	 */
	public static function instance() {

		if ( ! isset( self::$instance ) )
			self::$instance = new HMBKP_Services;

		return self::$instance;

	}

	/**
	 * Register a new service
	 *
	 * @param $filepath
	 * @param $classname
	 * @return bool|WP_Error

Should the return type not be boolean|WP_Error|null?

	 */
	public static function register( $filepath, $classname ) {

The parameter $filepath is not used and could be removed.

The parameter $classname is not used and could be removed.

		_deprecated_function( __METHOD__, '3.1.2' );
	}

	/**
	 * Instantiate the individual service classes
	 *
	 * @param string $classname
	 *
	 * @return array An array of instantiated classes

Should the return type not be object?

	 */
	private static function instantiate( $classname ) {

This method is not used, and could be removed.

		if ( ! class_exists( $classname ) )
			return new \WP_Error( 'hmbkp_invalid_type_error', sprintf( __( 'Argument 1 for %s must be a valid class', 'backupwordpress' ) ), __METHOD__ );

		/**
		 * @var HMBKP_Service
		 */
		$class = new $classname( self::instance()->schedule );

		return $class;

	}

}