hughcube / ipdb

src/Readers/IpDbReader.php

<?php

namespace HughCube\IpDb\Readers;

use HughCube\IpDb\Exceptions\DbFileException;

class IpDbReader extends Reader
{
    /**
     * @var false|resource
     */
    private $file;

    /**
     * @var string|null
     */
    private $database;

    /**
     * Reader constructor.
     *
     * @param $database
     *
     * @throws \Exception
     */
    public function __construct($database)
    {
        if (!is_readable($database)) {
            $message = "The IP Database file \"{$database}\" does not exist or is not readable.";

            throw new DbFileException($message);
        }

        $this->file = @fopen($database, 'rb');
        if (!is_resource($this->file)) {
            throw new DbFileException("IP Database File opening \"{$database}\".");
        }

        $this->database = $database;

        $this->init();
    }

    /**
     * @throws \Exception
     *
     * @return PHPReader
     */
    public function getPHPReader()
    {
        return new PHPReader($this->read(0, $this->fileSize));

It seems like $this->read(0, $this->fileSize) can also be of type false; however, parameter $data of HughCube\IpDb\Readers\PHPReader::__construct() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    protected function computeFileSize()
    {
        return @filesize($this->database);
    }

    /**
     * {@inheritdoc}
     */
    protected function read($offset, $length)
    {
        if (0 !== fseek($this->file, $offset)) {

It seems like $this->file can also be of type boolean; however, parameter $handle of fseek() does only seem to accept resource, maybe add an additional type check?

            return false;
        }

        return fread($this->file, $length);

It seems like $this->file can also be of type boolean; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function close()
    {
        if (is_resource($this->file)) {
            fclose($this->file);
        }
    }
}