HughCube\ACMClient\Commands\SyncConfig

Complexity

Total Complexity

8

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	syncConfig()	0	27	3
A	hashContents()	0	7	2
A	handle()	0	13	3

<?php

namespace HughCube\ACMClient\Commands;

use HughCube\ACMClient\ACM;
use HughCube\ACMClient\Client;
use Illuminate\Console\Command;

class SyncConfig extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'acm:sync-config
                            {dataId : Configured ID }
                            {file   : Configure saved file path } 
                            {--name=default : Name of the ACM client, default "default" } 
                            {--repeat=-1 : Number of repeated checks, -1 means unlimited, default "-1" } 
                            {--interval=1000 : Every check interval MS, default 1000 ms }';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Save the configuration of pull ACM to a file';

    /**
     * Execute the console command.
     *
     * @return void
     * @throws \Exception
     */
    public function handle()
    {
        $repeat = $this->option("repeat");
        $interval = $this->option("interval");

        $runCount = 0;
        do {

            $this->syncConfig();
            $runCount++;
            usleep($interval * 1000);

        } while (-1 == $repeat || $runCount < $repeat);
    }

    /**
     * @return bool
     * @throws \Exception
     */
    protected function syncConfig()
    {
        $dataId = $this->argument("dataId");
        $file = $this->argument('file');

        $connection = $this->option('name');

        /** @var Client $client */
        $client = ACM::connection($connection);

        $localContents = null;
        if (is_file($file)) {

It seems like $file can also be of type string[]; however, parameter $filename of is_file() does only seem to accept string, maybe add an additional type check?

            $localContents = file_get_contents($file);

It seems like $file can also be of type string[]; however, parameter $filename of file_get_contents() does only seem to accept string, maybe add an additional type check?

        }
        $localHash = $this->hashContents($localContents);

        $remoteContents = $client->read($dataId);

It seems like $dataId can also be of type null and string[]; however, parameter $dataId of HughCube\ACMClient\Client::read() does only seem to accept string, maybe add an additional type check?

        $remoteHash = $this->hashContents($remoteContents);

        if ($localHash === $remoteHash) {
            $this->line(sprintf("%s <info>文件无需同步, hash: %s</info>", date('Y-m-d H:i:s'), $remoteHash));
        } else {
            file_put_contents($file, $remoteContents, LOCK_EX);

It seems like $file can also be of type string[]; however, parameter $filename of file_put_contents() does only seem to accept string, maybe add an additional type check?

            $this->line(sprintf("%s <info>文件同步成功, hash: %s</info>", date('Y-m-d H:i:s'), $remoteHash));
        }

        return true;
    }

    protected function hashContents($contents)
    {
        if (null === $contents) {
            return null;
        }

        return md5($contents) . '-' . crc32($contents);;
    }
}