hughcube-php / laravel-wechat

src/Message/Event/UserMessageText.php

<?php
/**
 * Created by PhpStorm.
 * User: hugh.li
 * Date: 2022/2/24
 * Time: 17:35
 */

namespace HughCube\Laravel\WeChat\Message\Event;

use HughCube\Laravel\WeChat\Contracts\Message\Event\UserMessageText as Contract;
use HughCube\PUrl\HUrl;
use Illuminate\Support\Str;

class UserMessageText extends Event implements Contract
{
    public function getContent($trim = true): string
    {
        $content = $this->getMessage('Content');

        return $trim ? trim($content) : $content;

The expression return $trim ? trim($content) : $content could return the type array|null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

It seems like $content can also be of type array and null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

    }

    public function is($pattern, $trim = true): bool
    {
        return Str::is($pattern, $this->getContent($trim));
    }

    public function eq($string, $trim = true): bool
    {
        return $string === $this->getContent($trim);
    }

    public function contains($needles, $ignoreCase = false, $trim = true): bool
    {
        return Str::contains($this->getContent($trim), $needles, $ignoreCase);

The call to Illuminate\Support\Str::contains() has too many arguments starting with $ignoreCase.

    }

    public function getUrl(): ?HUrl
    {
        return HUrl::parse($this->getContent());
    }
}