hughcube-php / laravel-wechat

src/Message/Event/Event.php

<?php
/**
 * Created by PhpStorm.
 * User: hugh.li
 * Date: 2022/2/24
 * Time: 23:11
 */

namespace HughCube\Laravel\WeChat\Message\Event;

use Carbon\Carbon;

class Event implements \HughCube\Laravel\WeChat\Contracts\Message\Event\Event
{
    /**
     * @var array
     */
    protected $message;

    /**
     * @param  array  $message
     */
    public function __construct(array $message = [])
    {
        $this->message = $message;
    }

    /**
     * @param  string|null  $key
     * @return array|mixed|null
     */
    public function getMessage(?string $key = null)
    {
        if (null === $key) {
            return $this->message;
        }

        return $this->message[$key] ?? null;
    }

    public function getToUserName(): ?string
    {
        return $this->getMessage('ToUserName');

The expression return $this->getMessage('ToUserName') could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public function getFromUserName(): ?string
    {
        return $this->getMessage('FromUserName');

The expression return $this->getMessage('FromUserName') could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public function getMessageType(): ?string
    {
        return $this->getMessage('MsgType');

The expression return $this->getMessage('MsgType') could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public function getCreatedAt(): ?Carbon
    {
        $timestamp = $this->getMessage('CreateTime');
        if (empty($timestamp)) {
            return null;
        }
        return Carbon::createFromTimestamp($timestamp);

It seems like $timestamp can also be of type array; however, parameter $timestamp of Carbon\Carbon::createFromTimestamp() does only seem to accept double|integer|string, maybe add an additional type check?

    }

    public function getMessageId(): ?int
    {
        return $this->getMessage('MsgId') ?: $this->getMessage('MsgID');

The expression return $this->getMessage('MsgId') ?: $this->getMessage('MsgID') could return the type array which is incompatible with the type-hinted return integer|null. Consider adding an additional type-check to rule them out.

    }

    public function getEvent(): ?string
    {
        return $this->getMessage('Event');

The expression return $this->getMessage('Event') could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public function getEventKey()
    {
        return $this->getMessage('EventKey');
    }

    public function getOpenID(): ?string
    {
        return $this->getFromUserName();
    }
}