HughCube\Laravel\WeChat\Message\Event\UserMessageText

Complexity

Total Complexity

6

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	contains()	0	3	1
A	eq()	0	3	1
A	getUrl()	0	3	1
A	is()	0	3	1
A	getContent()	0	5	2

<?php
/**
 * Created by PhpStorm.
 * User: hugh.li
 * Date: 2022/2/24
 * Time: 17:35
 */

namespace HughCube\Laravel\WeChat\Message\Event;

use HughCube\Laravel\WeChat\Contracts\Message\Event\UserMessageText as Contract;
use HughCube\PUrl\Url;
use Illuminate\Support\Str;

class UserMessageText extends Event implements Contract
{
    public function getContent($trim = true): string
    {
        $content = $this->getMessage('Content');

        return $trim ? trim($content) : $content;

The expression return $trim ? trim($content) : $content could return the type array|null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

It seems like $content can also be of type array and null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

    }

    public function is($pattern, $trim = true): bool
    {
        return Str::is($pattern, $this->getContent($trim));
    }

    public function eq($string, $trim = true): bool
    {
        return $string === $this->getContent($trim);
    }

    public function contains($needles, $ignoreCase = false, $trim = true): bool
    {
        return Str::contains($this->getContent($trim), $needles, $ignoreCase);

The call to Illuminate\Support\Str::contains() has too many arguments starting with $ignoreCase.

    }

    public function getUrl(): ?Url
    {
        return Url::parse($this->getContent());
    }
}