Passed
Push — master ( 5d8234...592389 )
by
unknown
01:35
created
src/Routing/Conditions/PostId.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 	 * 
19 19
 	 * @param string $post_id
20 20
 	 */
21
-	public function __construct( $post_id ) {
21
+	public function __construct($post_id) {
22 22
 		$this->post_id = $post_id;
23 23
 	}
24 24
 
Please login to merge, or discard this patch.
src/Routing/Conditions/PostSlug.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 	 * 
19 19
 	 * @param string $post_slug
20 20
 	 */
21
-	public function __construct( $post_slug ) {
21
+	public function __construct($post_slug) {
22 22
 		$this->post_slug = $post_slug;
23 23
 	}
24 24
 
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	 */
28 28
 	public function satisfied() {
29 29
 		$post = get_post();
30
-		return ( $post && $this->post_slug === $post->post_name );
30
+		return ($post && $this->post_slug === $post->post_name);
31 31
 	}
32 32
 
33 33
 	/**
Please login to merge, or discard this patch.
src/Routing/Router.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 * @return null
21 21
 	 */
22 22
 	public function boot() {
23
-		add_action( 'template_include', array( $this, 'execute' ), 1000 );
23
+		add_action('template_include', array($this, 'execute'), 1000);
24 24
 	}
25 25
 
26 26
 	/**
@@ -29,17 +29,17 @@  discard block
 block discarded – undo
29 29
 	 * @param  string $template
30 30
 	 * @return string
31 31
 	 */
32
-	public function execute( $template ) {
32
+	public function execute($template) {
33 33
 		$routes = $this->getRoutes();
34
-		$global_middleware = Framework::resolve( 'framework.global_middleware' );
34
+		$global_middleware = Framework::resolve('framework.global_middleware');
35 35
 
36
-		foreach ( $routes as $route ) {
37
-			$route->addMiddleware( $global_middleware );
36
+		foreach ($routes as $route) {
37
+			$route->addMiddleware($global_middleware);
38 38
 		}
39 39
 
40
-		foreach ( $routes as $route ) {
41
-			if ( $route->satisfied() ) {
42
-				return $this->handle( $route );
40
+		foreach ($routes as $route) {
41
+			if ($route->satisfied()) {
42
+				return $this->handle($route);
43 43
 			}
44 44
 		}
45 45
 		
@@ -52,18 +52,18 @@  discard block
 block discarded – undo
52 52
 	 * @param  RouteInterface $route
53 53
 	 * @return string
54 54
 	 */
55
-	protected function handle( RouteInterface $route ) {
55
+	protected function handle(RouteInterface $route) {
56 56
 		$request = Request::fromGlobals();
57
-		$response = $route->handle( $request );
57
+		$response = $route->handle($request);
58 58
 
59
-		if ( ! is_a( $response, ResponseInterface::class ) ) {
60
-			if ( Framework::debugging() ) {
61
-				throw new Exception( 'Response returned by controller is not valid (expectected ' . ResponseInterface::class . '; received ' . gettype( $response ) . ').' );
59
+		if ( ! is_a($response, ResponseInterface::class)) {
60
+			if (Framework::debugging()) {
61
+				throw new Exception('Response returned by controller is not valid (expectected ' . ResponseInterface::class . '; received ' . gettype($response) . ').');
62 62
 			}
63
-			$response = FrameworkResponse::error( FrameworkResponse::response(), 500 );
63
+			$response = FrameworkResponse::error(FrameworkResponse::response(), 500);
64 64
 		}
65 65
 
66
-		add_filter( 'carbon_framework_response', function() use ( $response ) {
66
+		add_filter('carbon_framework_response', function() use ($response) {
67 67
 			return $response;
68 68
 		} );
69 69
 
Please login to merge, or discard this patch.
src/Routing/HasRoutesInterface.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param RouteInterface  $route
22 22
 	 * @return RouteInterface
23 23
 	 */
24
-	public function addRoute( $route );
24
+	public function addRoute($route);
25 25
 
26 26
 	/**
27 27
 	 * Create and add a new route
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	 * @param  string|Closure $handler
32 32
 	 * @return RouteInterface
33 33
 	 */
34
-	public function route( $methods, $target, $handler );
34
+	public function route($methods, $target, $handler);
35 35
 
36 36
 	/**
37 37
 	 * Create and add a route group
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @param  Closure        $callable
41 41
 	 * @return RouteInterface
42 42
 	 */
43
-	public function group( $target, Closure $callable );
43
+	public function group($target, Closure $callable);
44 44
 
45 45
 	/**
46 46
 	 * Create and add a route for the GET and HEAD methods
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 	 * @param  string|Closure $handler
50 50
 	 * @return RouteInterface
51 51
 	 */
52
-	public function get( $target, $handler );
52
+	public function get($target, $handler);
53 53
 
54 54
 	/**
55 55
 	 * Create and add a route for the POST method
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	 * @param  string|Closure $handler
59 59
 	 * @return RouteInterface
60 60
 	 */
61
-	public function post( $target, $handler );
61
+	public function post($target, $handler);
62 62
 
63 63
 	/**
64 64
 	 * Create and add a route for the PUT method
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 	 * @param  string|Closure $handler
68 68
 	 * @return RouteInterface
69 69
 	 */
70
-	public function put( $target, $handler );
70
+	public function put($target, $handler);
71 71
 
72 72
 	/**
73 73
 	 * Create and add a route for the PATCH method
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 * @param  string|Closure $handler
77 77
 	 * @return RouteInterface
78 78
 	 */
79
-	public function patch( $target, $handler );
79
+	public function patch($target, $handler);
80 80
 
81 81
 	/**
82 82
 	 * Create and add a route for the DELETE method
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 * @param  string|Closure $handler
86 86
 	 * @return RouteInterface
87 87
 	 */
88
-	public function delete( $target, $handler );
88
+	public function delete($target, $handler);
89 89
 
90 90
 	/**
91 91
 	 * Create and add a route for the OPTIONS method
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 * @param  string|Closure $handler
95 95
 	 * @return RouteInterface
96 96
 	 */
97
-	public function options( $target, $handler );
97
+	public function options($target, $handler);
98 98
 
99 99
 	/**
100 100
 	 * Create and add a route for all supported methods
@@ -103,5 +103,5 @@  discard block
 block discarded – undo
103 103
 	 * @param  string|Closure $handler
104 104
 	 * @return RouteInterface
105 105
 	 */
106
-	public function any( $target, $handler );
106
+	public function any($target, $handler);
107 107
 }
Please login to merge, or discard this patch.
src/Routing/RouteGroup.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -30,18 +30,18 @@  discard block
 block discarded – undo
30 30
 	 * @param string|ConditionInterface $target
31 31
 	 * @param Closure                   $callable
32 32
 	 */
33
-	public function __construct( $target, Closure $callable ) {
34
-		if ( is_string( $target ) ) {
35
-			$target = new UrlCondition( $target );
33
+	public function __construct($target, Closure $callable) {
34
+		if (is_string($target)) {
35
+			$target = new UrlCondition($target);
36 36
 		}
37 37
 
38
-		if ( ! is_a( $target, UrlCondition::class ) ) {
39
-			throw new Exception( 'Route groups can only use route strings.' );
38
+		if ( ! is_a($target, UrlCondition::class)) {
39
+			throw new Exception('Route groups can only use route strings.');
40 40
 		}
41 41
 
42 42
 		$this->target = $target;
43 43
 
44
-		$callable( $this );
44
+		$callable($this);
45 45
 	}
46 46
 
47 47
 	/**
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 	 */
52 52
 	protected function getSatisfiedRoute() {
53 53
 		$routes = $this->getRoutes();
54
-		foreach ( $routes as $route ) {
55
-			if ( $route->satisfied() ) {
54
+		foreach ($routes as $route) {
55
+			if ($route->satisfied()) {
56 56
 				return $route;
57 57
 			}
58 58
 		}
@@ -70,37 +70,37 @@  discard block
 block discarded – undo
70 70
 	/**
71 71
 	 * {@inheritDoc}
72 72
 	 */
73
-	public function handle( $request ) {
73
+	public function handle($request) {
74 74
 		$route = $this->getSatisfiedRoute();
75
-		return $route ? $route->handle( $request ) : null;
75
+		return $route ? $route->handle($request) : null;
76 76
 	}
77 77
 
78 78
 	/**
79 79
 	 * {@inheritDoc}
80 80
 	 */
81
-	public function route( $methods, $target, $handler ) {
82
-		if ( is_string( $target ) ) {
83
-			$target = new UrlCondition( $target );
81
+	public function route($methods, $target, $handler) {
82
+		if (is_string($target)) {
83
+			$target = new UrlCondition($target);
84 84
 		}
85 85
 
86
-		if ( ! is_a( $target, UrlCondition::class ) ) {
87
-			throw new Exception( 'Routes inside route groups can only use route strings.' );
86
+		if ( ! is_a($target, UrlCondition::class)) {
87
+			throw new Exception('Routes inside route groups can only use route strings.');
88 88
 		}
89 89
 
90
-		$target = $this->target->concatenate( $target );
91
-		return $this->traitRoute( $methods, $target, $handler );
90
+		$target = $this->target->concatenate($target);
91
+		return $this->traitRoute($methods, $target, $handler);
92 92
 	}
93 93
 
94 94
 	/**
95 95
 	 * {@inheritDoc}
96 96
 	 */
97
-	public function addMiddleware( $middleware ) {
97
+	public function addMiddleware($middleware) {
98 98
 		$routes = $this->getRoutes();
99 99
 
100
-		foreach ( $routes as $route ) {
101
-			$route->addMiddleware( $middleware );
100
+		foreach ($routes as $route) {
101
+			$route->addMiddleware($middleware);
102 102
 		}
103 103
 		
104
-		return $this->traitAddMiddleware( $middleware );
104
+		return $this->traitAddMiddleware($middleware);
105 105
 	}
106 106
 }
Please login to merge, or discard this patch.
src/Routing/Conditions/Url.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 	 * 
43 43
 	 * @param string $url
44 44
 	 */
45
-	public function __construct( $url ) {
46
-		$url = UrlUtility::addLeadingSlash( $url );
47
-		$url = UrlUtility::addTrailingSlash( $url );
45
+	public function __construct($url) {
46
+		$url = UrlUtility::addLeadingSlash($url);
47
+		$url = UrlUtility::addTrailingSlash($url);
48 48
 		$this->url = $url;
49 49
 	}
50 50
 
@@ -52,28 +52,28 @@  discard block
 block discarded – undo
52 52
 	 * {@inheritDoc}
53 53
 	 */
54 54
 	public function satisfied() {
55
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
55
+		$validation_regex = $this->getValidationRegex($this->getUrl());
56 56
 		$url = $this->getCurrentPath();
57
-		return (bool) preg_match( $validation_regex, $url );
57
+		return (bool) preg_match($validation_regex, $url);
58 58
 	}
59 59
 
60 60
 	/**
61 61
 	 * {@inheritDoc}
62 62
 	 */
63 63
 	public function getArguments() {
64
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
64
+		$validation_regex = $this->getValidationRegex($this->getUrl());
65 65
 		$url = $this->getCurrentPath();
66 66
 		$matches = [];
67
-		$success = preg_match( $validation_regex, $url, $matches );
67
+		$success = preg_match($validation_regex, $url, $matches);
68 68
 
69
-		if ( ! $success ) {
69
+		if ( ! $success) {
70 70
 			return []; // this should not normally happen
71 71
 		}
72 72
 
73 73
 		$arguments = [];
74
-		$parameter_names = $this->getParameterNames( $this->getUrl() );
75
-		foreach ( $parameter_names as $parameter_name ) {
76
-			$arguments[] = ! empty( $matches[ $parameter_name ] ) ? $matches[ $parameter_name ] : '';
74
+		$parameter_names = $this->getParameterNames($this->getUrl());
75
+		foreach ($parameter_names as $parameter_name) {
76
+			$arguments[] = ! empty($matches[$parameter_name]) ? $matches[$parameter_name] : '';
77 77
 		}
78 78
 		
79 79
 		return $arguments;
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 * @return string
95 95
 	 */
96 96
 	protected function getCurrentPath() {
97
-		return UrlUtility::addTrailingSlash( UrlUtility::getCurrentPath() );
97
+		return UrlUtility::addTrailingSlash(UrlUtility::getCurrentPath());
98 98
 	}
99 99
 
100 100
 	/**
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
 	 * @param  Url $url
104 104
 	 * @return Url
105 105
 	 */
106
-	public function concatenate( Url $url ) {
107
-		return new static( UrlUtility::removeTrailingSlash( $this->getUrl() ) . $url->getUrl() );
106
+	public function concatenate(Url $url) {
107
+		return new static(UrlUtility::removeTrailingSlash($this->getUrl()) . $url->getUrl());
108 108
 	}
109 109
 
110 110
 	/**
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
 	 * @param  string   $url
114 114
 	 * @return string[]
115 115
 	 */
116
-	protected function getParameterNames( $url ) {
116
+	protected function getParameterNames($url) {
117 117
 		$matches = [];
118
-		preg_match_all( $this->url_regex, $url, $matches );
118
+		preg_match_all($this->url_regex, $url, $matches);
119 119
 		return $matches['name'];
120 120
 	}
121 121
 
@@ -125,29 +125,29 @@  discard block
 block discarded – undo
125 125
 	 * @param  string $url
126 126
 	 * @return string
127 127
 	 */
128
-	protected function getValidationRegex( $url ) {
128
+	protected function getValidationRegex($url) {
129 129
 		$parameters = [];
130 130
 
131 131
 		// Replace all parameters with placeholders
132
-		$validation_regex = preg_replace_callback( $this->url_regex, function( $matches ) use ( &$parameters ) {
132
+		$validation_regex = preg_replace_callback($this->url_regex, function($matches) use (&$parameters) {
133 133
 			$name = $matches['name'];
134
-			$optional = ! empty( $matches['optional'] );
135
-			$regex = ! empty( $matches['regex'] ) ? $matches['regex'] : $this->parameter_regex;
134
+			$optional = ! empty($matches['optional']);
135
+			$regex = ! empty($matches['regex']) ? $matches['regex'] : $this->parameter_regex;
136 136
 			$replacement = '(?:/(?P<' . $name . '>' . $regex . '))';
137
-			if ( $optional ) {
137
+			if ($optional) {
138 138
 				$replacement .= '?';
139 139
 			}
140 140
 
141
-			$placeholder = '___placeholder_' . sha1( count( $parameters) . '_' . $replacement . '_' . uniqid() ) . '___';
142
-			$parameters[ $placeholder ] = $replacement;
141
+			$placeholder = '___placeholder_' . sha1(count($parameters) . '_' . $replacement . '_' . uniqid()) . '___';
142
+			$parameters[$placeholder] = $replacement;
143 143
 			return $placeholder;
144
-		}, $url );
144
+		}, $url);
145 145
 
146 146
 		// quote the remaining string so that it does not get evaluated as regex
147
-		$validation_regex = preg_quote( $validation_regex, '~' );
147
+		$validation_regex = preg_quote($validation_regex, '~');
148 148
 
149 149
 		// replace the placeholders with the real parameter regexes
150
-		$validation_regex = str_replace( array_keys( $parameters ), array_values( $parameters ), $validation_regex );
150
+		$validation_regex = str_replace(array_keys($parameters), array_values($parameters), $validation_regex);
151 151
 
152 152
 		// make sure that the regex matches the entire string
153 153
 		$validation_regex = '~\A' . $validation_regex . '\z~';
Please login to merge, or discard this patch.
src/ServiceProviders/OldInput.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -12,22 +12,22 @@
 block discarded – undo
12 12
 	/**
13 13
 	 * {@inheritDoc}
14 14
 	 */
15
-	public function register( $container ) {
16
-		$container['framework.global_middleware'] = array_merge( $container['framework.global_middleware'], [
15
+	public function register($container) {
16
+		$container['framework.global_middleware'] = array_merge($container['framework.global_middleware'], [
17 17
 			OldInputMiddleware::class,
18
-		] );
18
+		]);
19 19
 
20 20
 		$container['framework.old_input.old_input'] = function() {
21 21
 			return new \CarbonFramework\Input\OldInput();
22 22
 		};
23 23
 
24
-		Framework::facade( 'OldInput', \CarbonFramework\Facades\OldInput::class );
24
+		Framework::facade('OldInput', \CarbonFramework\Facades\OldInput::class);
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * {@inheritDoc}
29 29
 	 */
30
-	public function boot( $container ) {
30
+	public function boot($container) {
31 31
 		// nothing to boot
32 32
 	}
33 33
 }
34 34
\ No newline at end of file
Please login to merge, or discard this patch.
src/ServiceProviders/Templating.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * {@inheritDoc}
13 13
 	 */
14
-	public function register( $container ) {
14
+	public function register($container) {
15 15
 		$container['framework.templating.engine'] = function() {
16 16
 			return new \CarbonFramework\Templating\Php();
17 17
 		};
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	/**
21 21
 	 * {@inheritDoc}
22 22
 	 */
23
-	public function boot( $container ) {
23
+	public function boot($container) {
24 24
 		// nothing to boot
25 25
 	}
26 26
 }
27 27
\ No newline at end of file
Please login to merge, or discard this patch.
src/ServiceProviders/Routing.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * {@inheritDoc}
13 13
 	 */
14
-	public function register( $container ) {
15
-		$container['framework.config'] = array_merge( [
14
+	public function register($container) {
15
+		$container['framework.config'] = array_merge([
16 16
 			'global_middleware' => [],
17
-		], $container['framework.config'] );
17
+		], $container['framework.config']);
18 18
 
19 19
 		$container['framework.global_middleware'] = $container['framework.config']['global_middleware'];
20
-		$container['framework.global_middleware'] = apply_filters( 'carbon_framework_global_middleware', $container['framework.global_middleware'] );
20
+		$container['framework.global_middleware'] = apply_filters('carbon_framework_global_middleware', $container['framework.global_middleware']);
21 21
 
22 22
 		$container['framework.routing.conditions.custom'] = \CarbonFramework\Routing\Conditions\Custom::class;
23 23
 		$container['framework.routing.conditions.url'] = \CarbonFramework\Routing\Conditions\Url::class;
@@ -30,13 +30,13 @@  discard block
 block discarded – undo
30 30
 			return new \CarbonFramework\Routing\Router();
31 31
 		};
32 32
 
33
-		Framework::facade( 'Router', \CarbonFramework\Facades\Router::class );
33
+		Framework::facade('Router', \CarbonFramework\Facades\Router::class);
34 34
 	}
35 35
 
36 36
 	/**
37 37
 	 * {@inheritDoc}
38 38
 	 */
39
-	public function boot( $container ) {
39
+	public function boot($container) {
40 40
 		\Router::boot(); // facade
41 41
 	}
42 42
 }
43 43
\ No newline at end of file
Please login to merge, or discard this patch.