Test Failed
Branch master (04392b)
by htmlBurger
01:37
created
src/Routing/Conditions/Url.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -43,38 +43,38 @@  discard block
 block discarded – undo
43 43
 	 * 
44 44
 	 * @param string $url
45 45
 	 */
46
-	public function __construct( $url ) {
47
-		$url = UrlUtility::addLeadingSlash( $url );
48
-		$url = UrlUtility::addTrailingSlash( $url );
46
+	public function __construct($url) {
47
+		$url = UrlUtility::addLeadingSlash($url);
48
+		$url = UrlUtility::addTrailingSlash($url);
49 49
 		$this->url = $url;
50 50
 	}
51 51
 
52 52
 	/**
53 53
 	 * {@inheritDoc}
54 54
 	 */
55
-	public function satisfied( Request $request ) {
56
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
57
-		$url = UrlUtility::getCurrentPath( $request );
58
-		return (bool) preg_match( $validation_regex, $url );
55
+	public function satisfied(Request $request) {
56
+		$validation_regex = $this->getValidationRegex($this->getUrl());
57
+		$url = UrlUtility::getCurrentPath($request);
58
+		return (bool) preg_match($validation_regex, $url);
59 59
 	}
60 60
 
61 61
 	/**
62 62
 	 * {@inheritDoc}
63 63
 	 */
64
-	public function getArguments( Request $request ) {
65
-		$validation_regex = $this->getValidationRegex( $this->getUrl() );
66
-		$url = UrlUtility::getCurrentPath( $request );
64
+	public function getArguments(Request $request) {
65
+		$validation_regex = $this->getValidationRegex($this->getUrl());
66
+		$url = UrlUtility::getCurrentPath($request);
67 67
 		$matches = [];
68
-		$success = preg_match( $validation_regex, $url, $matches );
68
+		$success = preg_match($validation_regex, $url, $matches);
69 69
 
70
-		if ( ! $success ) {
70
+		if ( ! $success) {
71 71
 			return []; // this should not normally happen
72 72
 		}
73 73
 
74 74
 		$arguments = [];
75
-		$parameter_names = $this->getParameterNames( $this->getUrl() );
76
-		foreach ( $parameter_names as $parameter_name ) {
77
-			$arguments[] = ! empty( $matches[ $parameter_name ] ) ? $matches[ $parameter_name ] : '';
75
+		$parameter_names = $this->getParameterNames($this->getUrl());
76
+		foreach ($parameter_names as $parameter_name) {
77
+			$arguments[] = ! empty($matches[$parameter_name]) ? $matches[$parameter_name] : '';
78 78
 		}
79 79
 		
80 80
 		return $arguments;
@@ -95,8 +95,8 @@  discard block
 block discarded – undo
95 95
 	 * @param  Url $url
96 96
 	 * @return Url
97 97
 	 */
98
-	public function concatenate( Url $url ) {
99
-		return new static( UrlUtility::removeTrailingSlash( $this->getUrl() ) . $url->getUrl() );
98
+	public function concatenate(Url $url) {
99
+		return new static(UrlUtility::removeTrailingSlash($this->getUrl()) . $url->getUrl());
100 100
 	}
101 101
 
102 102
 	/**
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
105 105
 	 * @param  string   $url
106 106
 	 * @return string[]
107 107
 	 */
108
-	protected function getParameterNames( $url ) {
108
+	protected function getParameterNames($url) {
109 109
 		$matches = [];
110
-		preg_match_all( $this->url_regex, $url, $matches );
110
+		preg_match_all($this->url_regex, $url, $matches);
111 111
 		return $matches['name'];
112 112
 	}
113 113
 
@@ -117,29 +117,29 @@  discard block
 block discarded – undo
117 117
 	 * @param  string $url
118 118
 	 * @return string
119 119
 	 */
120
-	protected function getValidationRegex( $url ) {
120
+	protected function getValidationRegex($url) {
121 121
 		$parameters = [];
122 122
 
123 123
 		// Replace all parameters with placeholders
124
-		$validation_regex = preg_replace_callback( $this->url_regex, function( $matches ) use ( &$parameters ) {
124
+		$validation_regex = preg_replace_callback($this->url_regex, function($matches) use (&$parameters) {
125 125
 			$name = $matches['name'];
126
-			$optional = ! empty( $matches['optional'] );
127
-			$regex = ! empty( $matches['regex'] ) ? $matches['regex'] : $this->parameter_regex;
126
+			$optional = ! empty($matches['optional']);
127
+			$regex = ! empty($matches['regex']) ? $matches['regex'] : $this->parameter_regex;
128 128
 			$replacement = '(?:/(?P<' . $name . '>' . $regex . '))';
129
-			if ( $optional ) {
129
+			if ($optional) {
130 130
 				$replacement .= '?';
131 131
 			}
132 132
 
133
-			$placeholder = '___placeholder_' . sha1( count( $parameters) . '_' . $replacement . '_' . uniqid() ) . '___';
134
-			$parameters[ $placeholder ] = $replacement;
133
+			$placeholder = '___placeholder_' . sha1(count($parameters) . '_' . $replacement . '_' . uniqid()) . '___';
134
+			$parameters[$placeholder] = $replacement;
135 135
 			return $placeholder;
136
-		}, $url );
136
+		}, $url);
137 137
 
138 138
 		// quote the remaining string so that it does not get evaluated as regex
139
-		$validation_regex = preg_quote( $validation_regex, '~' );
139
+		$validation_regex = preg_quote($validation_regex, '~');
140 140
 
141 141
 		// replace the placeholders with the real parameter regexes
142
-		$validation_regex = str_replace( array_keys( $parameters ), array_values( $parameters ), $validation_regex );
142
+		$validation_regex = str_replace(array_keys($parameters), array_values($parameters), $validation_regex);
143 143
 
144 144
 		// make sure that the regex matches the entire string
145 145
 		$validation_regex = '~\A' . $validation_regex . '\z~';
Please login to merge, or discard this patch.
src/Routing/Conditions/PostType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,21 +20,21 @@
 block discarded – undo
20 20
 	 * 
21 21
 	 * @param string $post_type
22 22
 	 */
23
-	public function __construct( $post_type ) {
23
+	public function __construct($post_type) {
24 24
 		$this->post_type = $post_type;
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * {@inheritDoc}
29 29
 	 */
30
-	public function satisfied( Request $request ) {
30
+	public function satisfied(Request $request) {
31 31
 		return $this->post_type === get_post_type();
32 32
 	}
33 33
 
34 34
 	/**
35 35
 	 * {@inheritDoc}
36 36
 	 */
37
-	public function getArguments( Request $request ) {
37
+	public function getArguments(Request $request) {
38 38
 		return [$this->post_type];
39 39
 	}
40 40
 }
Please login to merge, or discard this patch.
src/Routing/Conditions/ConditionInterface.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	 * @param  Request $request
15 15
 	 * @return boolean
16 16
 	 */
17
-	public function satisfied( Request $request );
17
+	public function satisfied(Request $request);
18 18
 
19 19
 	/**
20 20
 	 * Return an array of arguments for use in request
@@ -22,5 +22,5 @@  discard block
 block discarded – undo
22 22
 	 * @param  Request $request
23 23
 	 * @return array
24 24
 	 */
25
-	public function getArguments( Request $request );
25
+	public function getArguments(Request $request);
26 26
 }
Please login to merge, or discard this patch.
src/Routing/Router.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 * @return null
21 21
 	 */
22 22
 	public function boot() {
23
-		add_action( 'template_include', array( $this, 'execute' ), 1000 );
23
+		add_action('template_include', array($this, 'execute'), 1000);
24 24
 	}
25 25
 
26 26
 	/**
@@ -29,18 +29,18 @@  discard block
 block discarded – undo
29 29
 	 * @param  string $template
30 30
 	 * @return string
31 31
 	 */
32
-	public function execute( $template ) {
32
+	public function execute($template) {
33 33
 		$routes = $this->getRoutes();
34
-		$global_middleware = Framework::resolve( 'framework.global_middleware' );
34
+		$global_middleware = Framework::resolve('framework.global_middleware');
35 35
 		$request = Request::fromGlobals();
36 36
 
37
-		foreach ( $routes as $route ) {
38
-			$route->addMiddleware( $global_middleware );
37
+		foreach ($routes as $route) {
38
+			$route->addMiddleware($global_middleware);
39 39
 		}
40 40
 
41
-		foreach ( $routes as $route ) {
42
-			if ( $route->satisfied( $request ) ) {
43
-				return $this->handle( $request, $route );
41
+		foreach ($routes as $route) {
42
+			if ($route->satisfied($request)) {
43
+				return $this->handle($request, $route);
44 44
 			}
45 45
 		}
46 46
 		
@@ -53,17 +53,17 @@  discard block
 block discarded – undo
53 53
 	 * @param  RouteInterface $route
54 54
 	 * @return string
55 55
 	 */
56
-	protected function handle( Request $request, RouteInterface $route ) {
57
-		$response = $route->handle( $request );
56
+	protected function handle(Request $request, RouteInterface $route) {
57
+		$response = $route->handle($request);
58 58
 
59
-		if ( ! is_a( $response, ResponseInterface::class ) ) {
60
-			if ( Framework::debugging() ) {
61
-				throw new Exception( 'Response returned by controller is not valid (expectected ' . ResponseInterface::class . '; received ' . gettype( $response ) . ').' );
59
+		if ( ! is_a($response, ResponseInterface::class)) {
60
+			if (Framework::debugging()) {
61
+				throw new Exception('Response returned by controller is not valid (expectected ' . ResponseInterface::class . '; received ' . gettype($response) . ').');
62 62
 			}
63
-			$response = FrameworkResponse::error( FrameworkResponse::response(), 500 );
63
+			$response = FrameworkResponse::error(FrameworkResponse::response(), 500);
64 64
 		}
65 65
 
66
-		add_filter( 'carbon_framework_response', function() use ( $response ) {
66
+		add_filter('carbon_framework_response', function() use ($response) {
67 67
 			return $response;
68 68
 		} );
69 69
 
Please login to merge, or discard this patch.
src/Routing/RouteInterface.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	 * @param  Request $request
16 16
 	 * @return boolean
17 17
 	 */
18
-	public function satisfied( Request $request );
18
+	public function satisfied(Request $request);
19 19
 
20 20
 	/**
21 21
 	 * Return a response for the given request
@@ -23,5 +23,5 @@  discard block
 block discarded – undo
23 23
 	 * @param  Request                             $request
24 24
 	 * @return \Psr\Http\Message\ResponseInterface
25 25
 	 */
26
-	public function handle( Request $request );
26
+	public function handle(Request $request);
27 27
 }
Please login to merge, or discard this patch.
src/Routing/RouteGroup.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -31,18 +31,18 @@  discard block
 block discarded – undo
31 31
 	 * @param string|ConditionInterface $target
32 32
 	 * @param Closure                   $callable
33 33
 	 */
34
-	public function __construct( $target, Closure $callable ) {
35
-		if ( is_string( $target ) ) {
36
-			$target = new UrlCondition( $target );
34
+	public function __construct($target, Closure $callable) {
35
+		if (is_string($target)) {
36
+			$target = new UrlCondition($target);
37 37
 		}
38 38
 
39
-		if ( ! is_a( $target, UrlCondition::class ) ) {
40
-			throw new Exception( 'Route groups can only use route strings.' );
39
+		if ( ! is_a($target, UrlCondition::class)) {
40
+			throw new Exception('Route groups can only use route strings.');
41 41
 		}
42 42
 
43 43
 		$this->target = $target;
44 44
 
45
-		$callable( $this );
45
+		$callable($this);
46 46
 	}
47 47
 
48 48
 	/**
@@ -50,10 +50,10 @@  discard block
 block discarded – undo
50 50
 	 * 
51 51
 	 * @return RouteInterface|null
52 52
 	 */
53
-	protected function getSatisfiedRoute( Request $request ) {
53
+	protected function getSatisfiedRoute(Request $request) {
54 54
 		$routes = $this->getRoutes();
55
-		foreach ( $routes as $route ) {
56
-			if ( $route->satisfied( $request ) ) {
55
+		foreach ($routes as $route) {
56
+			if ($route->satisfied($request)) {
57 57
 				return $route;
58 58
 			}
59 59
 		}
@@ -63,45 +63,45 @@  discard block
 block discarded – undo
63 63
 	/**
64 64
 	 * {@inheritDoc}
65 65
 	 */
66
-	public function satisfied( Request $request ) {
67
-		$route = $this->getSatisfiedRoute( $request );
66
+	public function satisfied(Request $request) {
67
+		$route = $this->getSatisfiedRoute($request);
68 68
 		return $route !== null;
69 69
 	}
70 70
 
71 71
 	/**
72 72
 	 * {@inheritDoc}
73 73
 	 */
74
-	public function handle( Request $request ) {
75
-		$route = $this->getSatisfiedRoute( $request );
76
-		return $route ? $route->handle( $request ) : null;
74
+	public function handle(Request $request) {
75
+		$route = $this->getSatisfiedRoute($request);
76
+		return $route ? $route->handle($request) : null;
77 77
 	}
78 78
 
79 79
 	/**
80 80
 	 * {@inheritDoc}
81 81
 	 */
82
-	public function route( $methods, $target, $handler ) {
83
-		if ( is_string( $target ) ) {
84
-			$target = new UrlCondition( $target );
82
+	public function route($methods, $target, $handler) {
83
+		if (is_string($target)) {
84
+			$target = new UrlCondition($target);
85 85
 		}
86 86
 
87
-		if ( ! is_a( $target, UrlCondition::class ) ) {
88
-			throw new Exception( 'Routes inside route groups can only use route strings.' );
87
+		if ( ! is_a($target, UrlCondition::class)) {
88
+			throw new Exception('Routes inside route groups can only use route strings.');
89 89
 		}
90 90
 
91
-		$target = $this->target->concatenate( $target );
92
-		return $this->traitRoute( $methods, $target, $handler );
91
+		$target = $this->target->concatenate($target);
92
+		return $this->traitRoute($methods, $target, $handler);
93 93
 	}
94 94
 
95 95
 	/**
96 96
 	 * {@inheritDoc}
97 97
 	 */
98
-	public function addMiddleware( $middleware ) {
98
+	public function addMiddleware($middleware) {
99 99
 		$routes = $this->getRoutes();
100 100
 
101
-		foreach ( $routes as $route ) {
102
-			$route->addMiddleware( $middleware );
101
+		foreach ($routes as $route) {
102
+			$route->addMiddleware($middleware);
103 103
 		}
104 104
 		
105
-		return $this->traitAddMiddleware( $middleware );
105
+		return $this->traitAddMiddleware($middleware);
106 106
 	}
107 107
 }
Please login to merge, or discard this patch.
src/Routing/Route.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -45,41 +45,41 @@  discard block
 block discarded – undo
45 45
 	 * @param mixed           $target
46 46
 	 * @param string|\Closure $handler
47 47
 	 */
48
-	public function __construct( $methods, $target, $handler ) {
49
-		if ( is_string( $target ) ) {
50
-			$target = new UrlCondition( $target );
48
+	public function __construct($methods, $target, $handler) {
49
+		if (is_string($target)) {
50
+			$target = new UrlCondition($target);
51 51
 		}
52 52
 
53
-		if ( is_array( $target ) ) {
54
-			$target = $this->condition( $target );
53
+		if (is_array($target)) {
54
+			$target = $this->condition($target);
55 55
 		}
56 56
 
57
-		if ( ! is_a( $target, ConditionInterface::class ) ) {
58
-			throw new Exception( 'Route target is not a valid route string or condition.' );
57
+		if ( ! is_a($target, ConditionInterface::class)) {
58
+			throw new Exception('Route target is not a valid route string or condition.');
59 59
 		}
60 60
 
61 61
 		$this->methods = $methods;
62 62
 		$this->target = $target;
63
-		$this->handler = new Handler( $handler );
63
+		$this->handler = new Handler($handler);
64 64
 	}
65 65
 
66 66
 	/**
67 67
 	 * {@inheritDoc}
68 68
 	 */
69
-	public function satisfied( Request $request ) {
70
-		if ( ! in_array( $request->getMethod(), $this->methods) ) {
69
+	public function satisfied(Request $request) {
70
+		if ( ! in_array($request->getMethod(), $this->methods)) {
71 71
 			return false;
72 72
 		}
73
-		return $this->target->satisfied( $request );
73
+		return $this->target->satisfied($request);
74 74
 	}
75 75
 
76 76
 	/**
77 77
 	 * {@inheritDoc}
78 78
 	 */
79
-	public function handle( Request $request ) {
80
-		$arguments = array_merge( [$request], $this->target->getArguments( $request ) );
81
-		return $this->executeMiddleware( $this->getMiddleware(), $request, function() use ( $arguments ) {
82
-			return call_user_func_array( [$this->handler, 'execute'], $arguments );
79
+	public function handle(Request $request) {
80
+		$arguments = array_merge([$request], $this->target->getArguments($request));
81
+		return $this->executeMiddleware($this->getMiddleware(), $request, function() use ($arguments) {
82
+			return call_user_func_array([$this->handler, 'execute'], $arguments);
83 83
 		} );
84 84
 	}
85 85
 
@@ -89,21 +89,21 @@  discard block
 block discarded – undo
89 89
 	 * @param  array $options
90 90
 	 * @return ConditionInterface
91 91
 	 */
92
-	public function condition( $options ) {
93
-		if ( count( $options ) === 0 ) {
94
-			throw new Exception( 'No condition type specified.' );
92
+	public function condition($options) {
93
+		if (count($options) === 0) {
94
+			throw new Exception('No condition type specified.');
95 95
 		}
96 96
 
97 97
 		$condition_type = $options[0];
98
-		$arguments = array_slice( $options, 1 );
98
+		$arguments = array_slice($options, 1);
99 99
 
100
-		$condition_class = Framework::resolve( 'framework.routing.conditions.' . $condition_type );
101
-		if ( $condition_class === null ) {
102
-			throw new Exception( 'Unknown condition type specified: ' . $condition_type );
100
+		$condition_class = Framework::resolve('framework.routing.conditions.' . $condition_type);
101
+		if ($condition_class === null) {
102
+			throw new Exception('Unknown condition type specified: ' . $condition_type);
103 103
 		}
104 104
 
105
-		$reflection = new ReflectionClass( $condition_class );
106
-		$condition = $reflection->newInstanceArgs( $arguments );
105
+		$reflection = new ReflectionClass($condition_class);
106
+		$condition = $reflection->newInstanceArgs($arguments);
107 107
 		return $condition;
108 108
 	}
109 109
 }
Please login to merge, or discard this patch.
src/Url.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -13,10 +13,10 @@  discard block
 block discarded – undo
13 13
 	 * 
14 14
 	 * @return string
15 15
 	 */
16
-	public static function getCurrentPath( Request $request ) {
16
+	public static function getCurrentPath(Request $request) {
17 17
 		$url = $request->getUrl();
18
-		$relative_url = substr( $url, strlen( home_url( '/' ) ) );
19
-		return static::addTrailingSlash( static::addLeadingSlash( $relative_url ) );
18
+		$relative_url = substr($url, strlen(home_url('/')));
19
+		return static::addTrailingSlash(static::addLeadingSlash($relative_url));
20 20
 	}
21 21
 
22 22
 	/**
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
25 25
 	 * @param  string $url
26 26
 	 * @return string
27 27
 	 */
28
-	public static function addLeadingSlash( $url ) {
29
-		return '/' . static::removeLeadingSlash( $url );
28
+	public static function addLeadingSlash($url) {
29
+		return '/' . static::removeLeadingSlash($url);
30 30
 	}
31 31
 
32 32
 	/**
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
35 35
 	 * @param  string $url
36 36
 	 * @return string
37 37
 	 */
38
-	public static function removeLeadingSlash( $url ) {
39
-		return preg_replace( '/^\/+/', '', $url );
38
+	public static function removeLeadingSlash($url) {
39
+		return preg_replace('/^\/+/', '', $url);
40 40
 	}
41 41
 
42 42
 	/**
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
 	 * @param  string $url
46 46
 	 * @return string
47 47
 	 */
48
-	public static function addTrailingSlash( $url ) {
49
-		return trailingslashit( $url );
48
+	public static function addTrailingSlash($url) {
49
+		return trailingslashit($url);
50 50
 	}
51 51
 
52 52
 	/**
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * @param  string $url
56 56
 	 * @return string
57 57
 	 */
58
-	public static function removeTrailingSlash( $url ) {
59
-		return untrailingslashit( $url );
58
+	public static function removeTrailingSlash($url) {
59
+		return untrailingslashit($url);
60 60
 	}
61 61
 }
Please login to merge, or discard this patch.