CarbonFramework\Middleware\HasMiddlewareTrait

Complexity

Total Complexity

12

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	isMiddleware()	0	11	3
A	getMiddleware()	0	3	1
A	addMiddleware()	0	12	4
A	add()	0	3	1
A	executeMiddleware()	0	18	3

<?php

namespace CarbonFramework\Middleware;

use Closure;
use Exception;
use Psr\Http\Message\ResponseInterface;

/**
 * Allow objects to have middleware
 */
trait HasMiddlewareTrait {
	/**
	 * Array of all registered middleware
	 *
	 * @var \CarbonFramework\Middleware\MiddlewareInterface[]
	 */
	protected $middleware = [];

	/**
	 * Check if the passed entity is a valid middleware
	 *
	 * @param  mixed   $middleware
	 * @return boolean
	 */
	protected function isMiddleware( $middleware ) {
		if ( is_callable( $middleware ) ) {
			return true;
		}

		if ( is_a( $middleware, MiddlewareInterface::class, true ) ) {

This if statement, and the following return statement can be replaced with return is_a($middleware, \CarbonFramework\Middleware\MiddlewareInterface::class, true);.

			return true;
		}

		return false;
	}

	/**
	 * Get registered middleware
	 *
	 * @return \CarbonFramework\Middleware\MiddlewareInterface[]
	 */
	public function getMiddleware() {
		return $this->middleware;
	}

	/**
	 * Add middleware
	 *
	 * @param  string|callable|\CarbonFramework\Middleware\MiddlewareInterface|array $middleware
	 * @return object                                                                $this

Should the return type not be HasMiddlewareTrait?

	 */
	public function addMiddleware( $middleware ) {
		$middleware = is_array( $middleware ) ? $middleware : [$middleware];

		foreach ( $middleware as $item ) {
			if ( ! $this->isMiddleware( $item ) ) {
				throw new Exception( 'Passed middleware must be a callable or the name of a class which implements the ' . MiddlewareInterface::class . ' interface.' );
			}
		}

		$this->middleware = array_merge( $this->getMiddleware(), $middleware );

It seems like array_merge($this->getMiddleware(), $middleware) of type array is incompatible with the declared type array<integer,object<CarbonFramework\Middleware\MiddlewareInterface>> of property $middleware.

		return $this;
	}

	/**
	 * Alias for addMiddleware
	 *
	 * @param  string|callable|\CarbonFramework\Middleware\middlewareInterface|array $middleware
	 * @return object                                                                $this

Should the return type not be HasMiddlewareTrait?

	 */
	public function add( $middleware ) {
		return $this->addMiddleware( $middleware );
	}

	/**
	 * Execute an array of middleware recursively (last in, first out)
	 *
	 * @param  \CarbonFramework\Middleware\MiddlewareInterface[] $middleware
	 * @param  \CarbonFramework\Request                          $request
	 * @param  Closure                                           $next
	 * @return ResponseInterface
	 */
	public function executeMiddleware( $middleware, $request, Closure $next ) {
		$top_middleware = array_pop( $middleware );

		if ( $top_middleware === null ) {
			return $next( $request );
		}

		$top_middleware_next = function( $request ) use ( $middleware, $next ) {
			return $this->executeMiddleware( $middleware, $request, $next );
		};

		if ( is_callable( $top_middleware ) ) {
			return call_user_func( $top_middleware, $request, $top_middleware_next );
		}

		$instance = new $top_middleware();
		return $instance->handle( $request, $top_middleware_next );
	}
}