Passed
Push — master ( 379f19...9ce0c5 )
by
unknown
06:34
created

OldInputMiddleware   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 18
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 1

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 1
dl 0
loc 18
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A handle() 0 13 3
1
<?php
2
3
namespace CarbonFramework\Input;
4
5
use Closure;
6
use Flash;
7
use OldInput;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, CarbonFramework\Input\OldInput.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
8
use CarbonFramework\Middleware\MiddlewareInterface;
9
10
/**
11
 * Flash current request data and clear old request data
12
 */
13
class OldInputMiddleware implements MiddlewareInterface {
14
	/**
15
	 * {@inheritDoc}
16
	 */
17
	public function handle( $request, Closure $next ) {
18
		$response = $next( $request );
19
20
		if ( Flash::enabled() ) {
21
			Flash::clear( OldInput::getFlashKey() );
22
23
			if ( $request->getMethod() === 'POST' ) {
24
				Flash::add( OldInput::getFlashKey(), $request->post() );
25
			}
26
		}
27
28
		return $response;
29
	}
30
}
31