AdminCondition - Code Metrics - Inspection of "Introduce admin condition" - htmlburger/wpemerge - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Branch — refactor/kernels (2fb3f9)

by Atanas

created 2019-04-10 21:33 UTC

AdminCondition A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	43
rs	10
c	0
b	0
f	0
wmc	6

3 Methods

Rating	Name	Size	Complexity
A	isSatisfied()	6	4
A	__construct()	3	1
A	getArguments()	2	1

<?php
/**
 * @package   WPEmerge
 * @author    Atanas Angelov <[email protected]>
 * @copyright 2018 Atanas Angelov
 * @license   https://www.gnu.org/licenses/gpl-2.0.html GPL-2.0
 * @link      https://wpemerge.com/
 */

namespace WPEmerge\Routing\Conditions;

use WPEmerge\Requests\RequestInterface;

/**
 * Check against the current ajax action.
 */
class AdminCondition implements ConditionInterface {
	/**
	 * Menu slug.
	 *
	 * @var string
	 */
	protected $menu = '';

	/**
	 * Parent menu slug.
	 *
	 * @var string
	 */
	protected $parent_menu = '';

	/**
	 * Constructor
	 *
	 * @codeCoverageIgnore
	 * @param string $menu
	 * @param string $parent_menu
	 */
	public function __construct( $menu, $parent_menu = '' ) {
		$this->menu = $menu;
		$this->parent_menu = $parent_menu;
	}

	/**
	 * {@inheritDoc}
	 */
	public function isSatisfied( RequestInterface $request ) {
		if ( ! is_admin() || ( defined( 'DOING_AJAX' ) && DOING_AJAX ) ) {
			return false;
		}

		return get_current_screen()->id === get_plugin_page_hookname( $this->menu, $this->parent_menu );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	}

	/**
	 * {@inheritDoc}
	 */
	public function getArguments( RequestInterface $request ) {
		return ['hook' => get_plugin_page_hookname( $this->menu, $this->parent_menu )];
	}
}


1			<?php
2			/**
3			* @package WPEmerge
4			* @author Atanas Angelov <[email protected]>
5			* @copyright 2018 Atanas Angelov
6			* @license https://www.gnu.org/licenses/gpl-2.0.html GPL-2.0
7			* @link https://wpemerge.com/
8			*/
9
10			namespace WPEmerge\Routing\Conditions;
11
12			use WPEmerge\Requests\RequestInterface;
13
14			/**
15			* Check against the current ajax action.
16			*/
17			class AdminCondition implements ConditionInterface {
18			/**
19			* Menu slug.
20			*
21			* @var string
22			*/
23			protected $menu = '';
24
25			/**
26			* Parent menu slug.
27			*
28			* @var string
29			*/
30			protected $parent_menu = '';
31
32			/**
33			* Constructor
34			*
35			* @codeCoverageIgnore
36			* @param string $menu
37			* @param string $parent_menu
38			*/
39			public function __construct( $menu, $parent_menu = '' ) {
40			$this->menu = $menu;
41			$this->parent_menu = $parent_menu;
42			}
43
44			/**
45			* {@inheritDoc}
46			*/
47			public function isSatisfied( RequestInterface $request ) {
48			if ( ! is_admin() \|\| ( defined( 'DOING_AJAX' ) && DOING_AJAX ) ) {
49			return false;
50			}
51
52			return get_current_screen()->id === get_plugin_page_hookname( $this->menu, $this->parent_menu );
			0 ignored issues – show Bug introduced 2019-04-10 21:35 UTC by Report Bug Copy Issue Report Are you sure the usage of `get_current_screen()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
53			}
54
55			/**
56			* {@inheritDoc}
57			*/
58			public function getArguments( RequestInterface $request ) {
59			return ['hook' => get_plugin_page_hookname( $this->menu, $this->parent_menu )];
60			}
61			}
62

htmlburger / wpemerge

Branch — refactor/kernels (2fb3f9)

AdminCondition A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like