PhpView::toString() - Code Metrics - Inspection of "rework view usage" - htmlburger/wpemerge - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a8bd8b...f2f9a5 )

by Atanas

created 2018-02-02 22:08 UTC

PhpView::toString() B

↳ Parent: PhpView

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	16
nc	3
nop	0
dl	0
loc	25
rs	8.8571
c	0
b	0
f	0
ccs	17
cts	17
cp	1
crap	3

<?php

namespace WPEmerge\View;

use Exception;
use GuzzleHttp\Psr7;
use GuzzleHttp\Psr7\Response;
use View as ViewService;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Render a view file with php.
 */
class PhpView implements ViewInterface {
	use HasContextTrait;

	/**
	 * View name.
	 *
	 * @var string
	 */
	protected $name = '';

	/**
	 * Filepath to view.
	 *
	 * @var string
	 */
	protected $filepath = '';

	/**
	 * {@inheritDoc}
	 */
	public function getName() {
		return $this->name;
	}

	/**
	 * {@inheritDoc}
	 */
	public function setName( $name ) {
		$this->name = $name;
		return $this;
	}

	/**
	 * Get filepath.
	 *
	 * @return string
	 */
	public function getFilepath() {
		return $this->filepath;
	}

	/**
	 * Set filepath.
	 *
	 * @param  string $filepath
	 * @return self   $this
	 */
	public function setFilepath( $filepath ) {
		$this->filepath = $filepath;
		return $this;
	}

	/**
	 * {@inheritDoc}
	 */
	public function toString() {
		if ( empty( $this->getName() ) ) {
			throw new Exception( 'View must have a name.' );
		}

		if ( empty( $this->getFilepath() ) ) {
			throw new Exception( 'View must have a filepath.' );
		}

		$global_context = ['global' => ViewService::getGlobals()];
		$local_context = $this->getContext();

		$this->with( $global_context );
		ViewService::compose( $this );
		$this->with( $local_context );

		$renderer = function() {
			ob_start();
			extract( $this->getContext() );

			include( $this->getFilepath() );
			return ob_get_clean();
		};

		return $renderer();
	}

	/**
	 * {@inheritDoc}
	 */
	public function toResponse() {
		return (new Response())
			->withHeader( 'Content-Type', 'text/html' )
			->withBody( Psr7\stream_for( $this->toString() ) );
	}
}


1		<?php
2
3		namespace WPEmerge\View;
4
5		use Exception;
6		use GuzzleHttp\Psr7;
7		use GuzzleHttp\Psr7\Response;
8		use View as ViewService;
		0 ignored issues – show Bug introduced 2018-02-02 22:10 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `WPEmerge\View\ViewService`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9
10		/**
11		* Render a view file with php.
12		*/
13		class PhpView implements ViewInterface {
14		use HasContextTrait;
15
16		/**
17		* View name.
18		*
19		* @var string
20		*/
21		protected $name = '';
22
23		/**
24		* Filepath to view.
25		*
26		* @var string
27		*/
28		protected $filepath = '';
29
30		/**
31		* {@inheritDoc}
32		*/
33	1	public function getName() {
34	1	return $this->name;
35		}
36
37		/**
38		* {@inheritDoc}
39		*/
40	1	public function setName( $name ) {
41	1	$this->name = $name;
42	1	return $this;
43		}
44
45		/**
46		* Get filepath.
47		*
48		* @return string
49		*/
50		public function getFilepath() {
51		return $this->filepath;
52		}
53
54		/**
55		* Set filepath.
56		*
57		* @param string $filepath
58		* @return self $this
59		*/
60		public function setFilepath( $filepath ) {
61		$this->filepath = $filepath;
62		return $this;
63		}
64
65		/**
66		* {@inheritDoc}
67		*/
68	7	public function toString() {
69	7	if ( empty( $this->getName() ) ) {
70	1	throw new Exception( 'View must have a name.' );
71		}
72
73	6	if ( empty( $this->getFilepath() ) ) {
74	1	throw new Exception( 'View must have a filepath.' );
75		}
76
77	5	$global_context = ['global' => ViewService::getGlobals()];
78	5	$local_context = $this->getContext();
79
80	5	$this->with( $global_context );
81	5	ViewService::compose( $this );
82	5	$this->with( $local_context );
83
84	5	$renderer = function() {
85	5	ob_start();
86	5	extract( $this->getContext() );
		0 ignored issues – show Bug introduced 2018-02-02 22:10 UTC by Report Bug Copy Issue Report `$this->getContext()` cannot be passed to `extract()` as the parameter `$var_array` expects a reference. Loading history...
87	5	include( $this->getFilepath() );
88	5	return ob_get_clean();
89	5	};
90
91	5	return $renderer();
92		}
93
94		/**
95		* {@inheritDoc}
96		*/
97		public function toResponse() {
98		return (new Response())
99		->withHeader( 'Content-Type', 'text/html' )
100		->withBody( Psr7\stream_for( $this->toString() ) );
101		}
102		}
103

htmlburger / wpemerge

Push — master ( a8bd8b...f2f9a5 )

PhpView::toString() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like