Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Value_Set { |
||
13 | |||
14 | /** |
||
15 | * Value type which saves a single value |
||
16 | */ |
||
17 | const TYPE_SINGLE_VALUE = 1; |
||
18 | |||
19 | /** |
||
20 | * Value type which saves multiple values with a single property |
||
21 | */ |
||
22 | const TYPE_MULTIPLE_VALUES = 2; |
||
23 | |||
24 | /** |
||
25 | * Value type which saves a single value with multiple proerties |
||
26 | */ |
||
27 | const TYPE_MULTIPLE_PROPERTIES = 3; |
||
28 | |||
29 | /** |
||
30 | * Value type which saves multiple values with multiple propertys |
||
31 | */ |
||
32 | const TYPE_VALUE_SET = 4; |
||
33 | |||
34 | /** |
||
35 | * Default value property required for every value set |
||
36 | */ |
||
37 | const VALUE_PROPERTY = 'value'; |
||
38 | |||
39 | /** |
||
40 | * Value set type |
||
41 | * |
||
42 | * @var integer static::TYPE_* constant |
||
43 | */ |
||
44 | protected $type = self::TYPE_SINGLE_VALUE; |
||
45 | |||
46 | /** |
||
47 | * Array of valid value set types |
||
48 | * |
||
49 | * @var array |
||
50 | */ |
||
51 | protected $valid_types = array( self::TYPE_SINGLE_VALUE, self::TYPE_MULTIPLE_VALUES, self::TYPE_MULTIPLE_PROPERTIES, self::TYPE_VALUE_SET ); |
||
52 | |||
53 | /** |
||
54 | * Array of empty values for every type |
||
55 | * |
||
56 | * @var array |
||
57 | */ |
||
58 | protected $empty_values = array( |
||
59 | self::TYPE_SINGLE_VALUE => '', |
||
60 | self::TYPE_MULTIPLE_VALUES => array(), |
||
61 | self::TYPE_MULTIPLE_PROPERTIES => array(), |
||
62 | self::TYPE_VALUE_SET => array(), |
||
63 | ); |
||
64 | |||
65 | /** |
||
66 | * Registered value set properties (properties) with their default value (when the property is missing in the passed raw_value_set) |
||
67 | * |
||
68 | * @var array |
||
69 | */ |
||
70 | protected $properties = array( self::VALUE_PROPERTY => '' ); |
||
71 | |||
72 | /** |
||
73 | * Data the value set represents |
||
74 | * |
||
75 | * @var null|array |
||
76 | */ |
||
77 | protected $value_set = null; |
||
78 | |||
79 | /** |
||
80 | * Value set constructor |
||
81 | * |
||
82 | * @param integer $type static::TYPE_* constant |
||
83 | * @param array $additional_properties |
||
84 | */ |
||
85 | 2 | public function __construct( $type = self::TYPE_SINGLE_VALUE, $additional_properties = array() ) { |
|
93 | |||
94 | /** |
||
95 | * Format a raw value set into one which guarantees that only (and all) registered properties are present |
||
96 | * |
||
97 | * @param array $raw_value_set |
||
98 | * @return array |
||
99 | */ |
||
100 | protected function get_formatted_value_set( $raw_value_set ) { |
||
111 | |||
112 | /** |
||
113 | * Return value set type |
||
114 | * |
||
115 | * @return int static::TYPE_* constant |
||
116 | */ |
||
117 | 1 | public function get_type() { |
|
120 | |||
121 | /** |
||
122 | * Return whether this value type requires a keepalive key |
||
123 | * |
||
124 | * @return boolean |
||
125 | */ |
||
126 | 2 | public function keepalive() { |
|
129 | |||
130 | /** |
||
131 | * Return whether the data is empty |
||
132 | * |
||
133 | * @return boolean |
||
134 | */ |
||
135 | 5 | public function is_empty() { |
|
138 | |||
139 | /** |
||
140 | * Return data formatted according to the value set $type |
||
141 | * |
||
142 | * @return null|string|array String, array of key-value pairs or array of arrays of key-value pairs |
||
143 | */ |
||
144 | 6 | public function get() { |
|
177 | |||
178 | /** |
||
179 | * Return the full value set data regardless of type |
||
180 | * |
||
181 | * @return array<array> |
||
182 | */ |
||
183 | 1 | public function get_set() { |
|
186 | |||
187 | /** |
||
188 | * Check if an array is flat |
||
189 | * |
||
190 | * @param array $array |
||
191 | * @return boolean |
||
192 | */ |
||
193 | protected function is_flat_array( $array ) { |
||
203 | |||
204 | /** |
||
205 | * Convert a flat array to a raw value set |
||
206 | * |
||
207 | * @param array $value_array |
||
208 | * @return array<array> |
||
209 | */ |
||
210 | protected function flat_array_to_raw_value_set( $value_array ) { |
||
235 | |||
236 | /** |
||
237 | * Set the value set data |
||
238 | * Accepts: single value, array of values, array of key-values, array of arrays of key-values |
||
239 | * |
||
240 | * @param null|string|array $raw_value_set String, indexed array, array of key-value pairs or array of arrays of key-value pairs |
||
241 | */ |
||
242 | 17 | public function set( $raw_value_set ) { |
|
258 | |||
259 | /** |
||
260 | * Clear the value with an appropriate "empty" one |
||
261 | */ |
||
262 | public function clear() { |
||
265 | } |