Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class Value_Set { |
||
| 13 | |||
| 14 | /** |
||
| 15 | * Value type which saves a single value |
||
| 16 | */ |
||
| 17 | const TYPE_SINGLE_VALUE = 1; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Value type which saves multiple values with a single property |
||
| 21 | */ |
||
| 22 | const TYPE_MULTIPLE_VALUES = 2; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Value type which saves a single value with multiple proerties |
||
| 26 | */ |
||
| 27 | const TYPE_MULTIPLE_PROPERTIES = 3; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Value type which saves multiple values with multiple propertys |
||
| 31 | */ |
||
| 32 | const TYPE_VALUE_SET = 4; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * Default value property required for every value set |
||
| 36 | */ |
||
| 37 | const VALUE_PROPERTY = 'value'; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * Value set type |
||
| 41 | * |
||
| 42 | * @var integer static::TYPE_* constant |
||
| 43 | */ |
||
| 44 | protected $type = self::TYPE_SINGLE_VALUE; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * Array of valid value set types |
||
| 48 | * |
||
| 49 | * @var array |
||
| 50 | */ |
||
| 51 | protected $valid_types = array( self::TYPE_SINGLE_VALUE, self::TYPE_MULTIPLE_VALUES, self::TYPE_MULTIPLE_PROPERTIES, self::TYPE_VALUE_SET ); |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Registered value set properties (properties) with their default value (when the property is missing in the passed raw_value_set) |
||
| 55 | * |
||
| 56 | * @var array |
||
| 57 | */ |
||
| 58 | protected $properties = array( self::VALUE_PROPERTY => '' ); |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Data the value set represents |
||
| 62 | * |
||
| 63 | * @var null|array |
||
| 64 | */ |
||
| 65 | protected $value_set = null; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * Value set constructor |
||
| 69 | * |
||
| 70 | * @param integer $type static::TYPE_* constant |
||
| 71 | * @param array $additional_properties |
||
| 72 | */ |
||
| 73 | 2 | public function __construct( $type = self::TYPE_SINGLE_VALUE, $additional_properties = array() ) { |
|
| 74 | 2 | if ( ! in_array( $type, $this->valid_types ) ) { |
|
| 75 | 1 | Incorrect_Syntax_Exception::raise( "Invalid type specified for Value_Set: $type" ); |
|
| 76 | } |
||
| 77 | |||
| 78 | 1 | $this->type = $type; |
|
| 79 | 1 | $this->properties = array_merge( $this->properties, $additional_properties ); |
|
| 80 | 1 | } |
|
| 81 | |||
| 82 | /** |
||
| 83 | * Format a raw value set into one which guarantees that only (and all) registered properties are present |
||
| 84 | * |
||
| 85 | * @param array $raw_value_set |
||
| 86 | * @return array |
||
| 87 | */ |
||
| 88 | protected function get_formatted_value_set( $raw_value_set ) { |
||
| 89 | $formatted_value_set = array(); |
||
| 90 | foreach ( $raw_value_set as $raw_value ) { |
||
| 91 | $formatted_value = array(); |
||
| 92 | foreach ( $this->properties as $property => $default_value ) { |
||
| 93 | $formatted_value[ $property ] = isset( $raw_value[ $property ] ) ? $raw_value[ $property ] : $default_value; |
||
| 94 | } |
||
| 95 | $formatted_value_set[] = $formatted_value; |
||
| 96 | } |
||
| 97 | return $formatted_value_set; |
||
| 98 | } |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Return value set type |
||
| 102 | * |
||
| 103 | * @return int static::TYPE_* constant |
||
| 104 | */ |
||
| 105 | 1 | public function get_type() { |
|
| 108 | |||
| 109 | /** |
||
| 110 | * Return whether this value type requires a keepalive key |
||
| 111 | * |
||
| 112 | * @return boolean |
||
| 113 | */ |
||
| 114 | 2 | public function keepalive() { |
|
| 117 | |||
| 118 | /** |
||
| 119 | * Return whether the data is empty |
||
| 120 | * |
||
| 121 | * @return boolean |
||
| 122 | */ |
||
| 123 | 5 | public function is_empty() { |
|
| 126 | |||
| 127 | /** |
||
| 128 | * Return data formatted according to the value set $type |
||
| 129 | * |
||
| 130 | * @return null|string|array String, array of key-value pairs or array of arrays of key-value pairs |
||
| 131 | */ |
||
| 132 | 6 | public function get() { |
|
| 133 | 6 | if ( $this->value_set === null ) { |
|
| 134 | 2 | return null; |
|
| 135 | } |
||
| 136 | 4 | $value = ''; |
|
| 137 | 4 | $value_property = static::VALUE_PROPERTY; |
|
| 138 | |||
| 139 | 4 | switch ( $this->type ) { |
|
| 140 | 4 | case static::TYPE_MULTIPLE_VALUES: |
|
| 141 | $value = array_map( function( $set ) use ( $value_property ) { |
||
| 142 | 1 | return $set[ $value_property ]; |
|
| 143 | 1 | }, $this->value_set ); |
|
| 144 | 1 | break; |
|
| 145 | 3 | View Code Duplication | case static::TYPE_MULTIPLE_PROPERTIES: |
| 146 | 1 | $value = array(); |
|
| 147 | 1 | if ( ! empty( $this->value_set ) ) { |
|
| 148 | 1 | $value = $this->value_set[0]; |
|
| 149 | } |
||
| 150 | 1 | break; |
|
| 151 | 2 | case static::TYPE_VALUE_SET: |
|
| 152 | 1 | $value = $this->value_set; |
|
| 153 | 1 | break; |
|
| 154 | |||
| 155 | 1 | case static::TYPE_SINGLE_VALUE: |
|
| 156 | View Code Duplication | default: |
|
| 157 | 1 | if ( ! empty( $this->value_set ) ) { |
|
| 158 | 1 | $value = $this->value_set[0][ static::VALUE_PROPERTY ]; |
|
| 159 | } |
||
| 160 | 1 | break; |
|
| 161 | } |
||
| 162 | |||
| 163 | 4 | return $value; |
|
| 164 | } |
||
| 165 | |||
| 166 | /** |
||
| 167 | * Return the full value set data regardless of type |
||
| 168 | * |
||
| 169 | * @return array<array> |
||
| 170 | */ |
||
| 171 | 1 | public function get_set() { |
|
| 174 | |||
| 175 | /** |
||
| 176 | * Check if an array is flat |
||
| 177 | * |
||
| 178 | * @param array $array |
||
| 179 | * @return boolean |
||
| 180 | */ |
||
| 181 | protected function is_flat_array( $array ) { |
||
| 191 | |||
| 192 | /** |
||
| 193 | * Convert a flat array to a raw value set |
||
| 194 | * |
||
| 195 | * @param array $value_array |
||
| 196 | * @return array<array> |
||
| 197 | */ |
||
| 198 | protected function flat_array_to_raw_value_set( $value_array ) { |
||
| 223 | |||
| 224 | /** |
||
| 225 | * Set the value set data |
||
| 226 | * Accepts: single value, array of values, array of key-values, array of arrays of key-values |
||
| 227 | * |
||
| 228 | * @param null|string|array $raw_value_set String, indexed array, array of key-value pairs or array of arrays of key-value pairs |
||
| 229 | */ |
||
| 230 | 17 | public function set( $raw_value_set ) { |
|
| 246 | } |