User_Role_Condition::is_fulfilled() - Code Metrics - Inspection of "fix static and dynamic condition evaluation and pa..." - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — milestone/2_0/container-condit... ( af96ef...c41f81 )

unknown

created 2017-02-28 09:17 UTC

User_Role_Condition::is_fulfilled() B

↳ Parent: User_Role_Condition

Complexity

Conditions	5
Paths	5

Size

Total Lines	24
Code Lines	19

Duplication

Lines	14
Ratio	58.33 %

Importance

Changes

Metric	Value
cc	5
eloc	19
nc	5
nop	1
dl	14
loc	24
rs	8.5125
c	0
b	0
f	0

<?php

namespace Carbon_Fields\Container\Condition;

/**
 * Check if user has a specific role
 * 
 * Operator "CUSTOM" is passed an array of all user roles
 */
class User_Role_Condition extends Condition {
	
	/**
	 * Check if the condition is fulfilled
	 * 
	 * @param  array $environment
	 * @return bool
	 */
	public function is_fulfilled( $environment ) {
		$roles = $environment['roles'];
		
		switch ( $this->get_comparison_operator() ) {

			case '=':
				return in_array( $this->get_value(), $roles );
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case '!=':
				return ! in_array( $this->get_value(), $roles );
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'IN':
				return count( array_intersect( $roles, $this->get_value() ) ) > 0;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'NOT IN':
				return count( array_intersect( $roles, $this->get_value() ) ) === 0;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}

		return $this->first_supported_comparer_is_correct(
			$roles,
			$this->get_comparison_operator(),
			$this->get_value()
		);
	}
}

1		<?php
2
3		namespace Carbon_Fields\Container\Condition;
4
5		/**
6		* Check if user has a specific role
7		*
8		* Operator "CUSTOM" is passed an array of all user roles
9		*/
10		class User_Role_Condition extends Condition {
11
12		/**
13		* Check if the condition is fulfilled
14		*
15		* @param array $environment
16		* @return bool
17		*/
18		public function is_fulfilled( $environment ) {
19		$roles = $environment['roles'];
20
21	View Code Duplication	switch ( $this->get_comparison_operator() ) {
		1 ignored issue – show Duplication introduced 2017-02-27 16:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		case '=':
23		return in_array( $this->get_value(), $roles );
24		break;
		1 ignored issue – show Unused Code introduced 2017-02-28 09:20 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
25		case '!=':
26		return ! in_array( $this->get_value(), $roles );
27		break;
		1 ignored issue – show Unused Code introduced 2017-02-28 09:20 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
28		case 'IN':
29		return count( array_intersect( $roles, $this->get_value() ) ) > 0;
30		break;
		1 ignored issue – show Unused Code introduced 2017-02-28 09:20 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
31		case 'NOT IN':
32		return count( array_intersect( $roles, $this->get_value() ) ) === 0;
33		break;
		1 ignored issue – show Unused Code introduced 2017-02-28 09:20 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
34		}
35
36		return $this->first_supported_comparer_is_correct(
37		$roles,
38		$this->get_comparison_operator(),
39		$this->get_value()
40		);
41		}
42		}

htmlburger / carbon-fields

Push — milestone/2_0/container-condit... ( af96ef...c41f81 )

User_Role_Condition::is_fulfilled() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like