Container_Condition_Provider - Code Metrics - Inspection of "enfore options api usage when deleting options" - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — milestone/2_0/react-ui ( 5b168c...b737dc )

unknown

created 2017-05-16 09:07 UTC

Container_Condition_Provider C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	313
Duplicated Lines	10.22 %

Coupling/Cohesion

Components	1
Dependencies	25

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	32
loc	313
ccs	0
cts	157
cp	0
rs	5
c	0
b	0
f	0
wmc	11
lcom	1
cbo	25

11 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	6	1
B	install_conditions()	32	122	1
B	install_comparers()	0	41	1
A	install_translators()	0	9	1
A	install_container_conditions()	0	19	1
A	filter_post_meta_container_static_condition_types()	0	6	1
A	filter_post_meta_container_dynamic_condition_types()	0	6	1
A	filter_term_meta_container_static_condition_types()	0	6	1
A	filter_term_meta_container_dynamic_condition_types()	0	6	1
A	filter_user_meta_container_static_condition_types()	0	6	1
A	filter_user_meta_container_dynamic_condition_types()	0	6	1

How to fix Duplicated Code

<?php

namespace Carbon_Fields\Provider;

use Carbon_Fields\Pimple\Container as PimpleContainer;
use Carbon_Fields\Pimple\ServiceProviderInterface;
use Carbon_Fields\Container\Condition\Factory as ConditionFactory;
use Carbon_Fields\Container\Fulfillable\Fulfillable_Collection;

class Container_Condition_Provider implements ServiceProviderInterface {

	/**
	 * Install dependencies in IoC container
	 *
	 * @param  PimpleContainer $ioc
	 */
	public function register( PimpleContainer $ioc ) {
		$this->install_conditions( $ioc );
		$this->install_comparers( $ioc );
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
		$this->install_translators( $ioc );
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
		$this->install_container_conditions( $ioc );
	}

	/**
	 * Install all codition types and the condition factory
	 *
	 * @param  PimpleContainer $ioc
	 */
	protected function install_conditions( $ioc ) {
		$ioc['container_condition_factory'] = function( $ioc ) {
			return new ConditionFactory( $ioc['container_conditions'] );
		};

		$ioc['container_condition_fulfillable_collection'] = $ioc->factory( function( $ioc ) {
			return new Fulfillable_Collection( $ioc['container_condition_factory'], $ioc['container_condition_translator_array'] );
		} );

		$ioc['container_conditions'] = function( $ioc ) {

			return new PimpleContainer();
		};

		$cc_ioc = $ioc['container_conditions'];

		$cc_ioc['boolean'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Boolean_Condition();
			$condition->set_comparers( array(
				$ioc['container_condition_comparers']['equality'],
			) );
			return $condition;
		} );

		$cc_ioc['post_id'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_ID_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );
		$cc_ioc['post_parent_id'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Parent_ID_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );
		$cc_ioc['post_type'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Type_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['nonscalar'] );
			return $condition;
		} );
		$cc_ioc['post_format'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Format_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['nonscalar'] );
			return $condition;
		} );
		$cc_ioc['post_level'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Level_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );
		$cc_ioc['post_template'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Template_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['nonscalar'] );
			return $condition;
		} );
		$cc_ioc['post_term'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Post_Term_Condition( $ioc['wp_toolset'] );
			$condition->set_comparers( array(
				// Only support the custom comparer as this condition has it's own comparison methods
				$ioc['container_condition_comparers']['custom'],
			) );
			return $condition;
		} );

		$cc_ioc['term'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Term_Condition( $ioc['wp_toolset'] );
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['nonscalar'] );
			return $condition;
		} );
		$cc_ioc['term_taxonomy'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Term_Taxonomy_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['nonscalar'] );
			return $condition;
		} );
		$cc_ioc['term_level'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Term_Level_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );

		$cc_ioc['user_id'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\User_ID_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );
		$cc_ioc['user_role'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\User_Role_Condition();
			$condition->set_comparers( array(
				// Only support the custom comparer as this condition has it's own comparison methods
				$ioc['container_condition_comparers']['custom'],
			) );
			return $condition;
		} );
		$cc_ioc['user_capabiltiy'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\User_Capability_Condition();
			$condition->set_comparers( array(
				// Only support the custom comparer as this condition has it's own comparison methods
				$ioc['container_condition_comparers']['custom'],
			) );
			return $condition;
		} );

		$cc_ioc['current_user_id'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Current_User_ID_Condition();
			$condition->set_comparers( $ioc['container_condition_comparer_collections']['generic'] );
			return $condition;
		} );
		$cc_ioc['current_user_role'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Current_User_Role_Condition();
			$condition->set_comparers( array(
				// Only support the custom comparer as this condition has it's own comparison methods
				$ioc['container_condition_comparers']['custom'],
			) );
			return $condition;
		} );
		$cc_ioc['current_user_capability'] = $cc_ioc->factory( function( $cc_ioc ) use ( $ioc ) {

			$condition = new \Carbon_Fields\Container\Condition\Current_User_Capability_Condition();
			$condition->set_comparers( array(
				// Only support the custom comparer as this condition has it's own comparison methods
				$ioc['container_condition_comparers']['custom'],
			) );
			return $condition;
		} );
	}

	/**
	 * Install all condition comparers
	 *
	 * @param  PimpleContainer $ioc
	 */
	protected function install_comparers( $ioc ) {
		$ioc['container_condition_comparers'] = function( $ioc ) {

			return new PimpleContainer();
		};

		$ioc['container_condition_comparers']['equality'] = function() {
			return new \Carbon_Fields\Container\Condition\Comparer\Equality_Comparer();
		};

		$ioc['container_condition_comparers']['contain'] = function() {
			return new \Carbon_Fields\Container\Condition\Comparer\Contain_Comparer();
		};

		$ioc['container_condition_comparers']['scalar'] = function() {
			return new \Carbon_Fields\Container\Condition\Comparer\Scalar_Comparer();
		};

		$ioc['container_condition_comparers']['custom'] = function() {
			return new \Carbon_Fields\Container\Condition\Comparer\Custom_Comparer();
		};

		$ioc['container_condition_comparer_collections'] = function( $ioc ) {

			return new PimpleContainer();
		};

		$ioc['container_condition_comparer_collections']['generic'] = function( $cccc_ioc ) use ( $ioc ) {

			return array(
				$ioc['container_condition_comparers']['equality'],
				$ioc['container_condition_comparers']['contain'],
				$ioc['container_condition_comparers']['scalar'],
				$ioc['container_condition_comparers']['custom'],
			);
		};
		$ioc['container_condition_comparer_collections']['nonscalar'] = function( $cccc_ioc ) use ( $ioc ) {

			return array(
				$ioc['container_condition_comparers']['equality'],
				$ioc['container_condition_comparers']['contain'],
				$ioc['container_condition_comparers']['custom'],
			);
		};
	}

	/**
	 * Install all codition translators
	 *
	 * @param  PimpleContainer $ioc
	 */
	protected static function install_translators( $ioc ) {
		$ioc['container_condition_translator_array'] = function( $ioc ) {
			return new \Carbon_Fields\Container\Fulfillable\Translator\Array_Translator( $ioc['container_condition_factory'] );
		};

		$ioc['container_condition_translator_json'] = function( $ioc ) {
			return new \Carbon_Fields\Container\Fulfillable\Translator\Json_Translator( $ioc['container_condition_factory'] );
		};
	}

	/**
	 * Install all container coditions
	 *
	 * @param  PimpleContainer $ioc
	 */
	protected function install_container_conditions( $ioc ) {
		// add current_user_* static condition types to all containers
		add_filter( 'carbon_fields_container_static_condition_types', function( $condition_types, $container_type, $container ) {
			return array_merge(
				$condition_types,
				array( 'current_user_id', 'current_user_role', 'current_user_capability' )
			);
		}, 10, 3 );

		// add container-specific conditions
		add_filter( 'carbon_fields_post_meta_container_static_condition_types', array( $this, 'filter_post_meta_container_static_condition_types' ), 10, 3 );
		add_filter( 'carbon_fields_post_meta_container_dynamic_condition_types', array( $this, 'filter_post_meta_container_dynamic_condition_types' ), 10, 3 );

		add_filter( 'carbon_fields_term_meta_container_static_condition_types', array( $this, 'filter_term_meta_container_static_condition_types' ), 10, 3 );
		add_filter( 'carbon_fields_term_meta_container_dynamic_condition_types', array( $this, 'filter_term_meta_container_dynamic_condition_types' ), 10, 3 );

		add_filter( 'carbon_fields_user_meta_container_static_condition_types', array( $this, 'filter_user_meta_container_static_condition_types' ), 10, 3 );
		add_filter( 'carbon_fields_user_meta_container_dynamic_condition_types', array( $this, 'filter_user_meta_container_dynamic_condition_types' ), 10, 3 );
	}

	/**
	 * Filter the Post_Meta_Container static condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_post_meta_container_static_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'post_id', 'post_type' )
		);
	}

	/**
	 * Filter the Post_Meta_Container dynamic condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_post_meta_container_dynamic_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'post_parent_id', 'post_format', 'post_level', 'post_template', 'post_term' )
		);
	}

	/**
	 * Filter the Term_Meta_Container static condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_term_meta_container_static_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'term', 'term_taxonomy' )
		);
	}

	/**
	 * Filter the Term_Meta_Container dynamic condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_term_meta_container_dynamic_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'term_level' )
		);
	}

	/**
	 * Filter the User_Meta_Container static condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_user_meta_container_static_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'user_id', 'user_capability' )
		);
	}

	/**
	 * Filter the User_Meta_Container dynamic condition types
	 *
	 * @param  array<string>                     $condition_types
	 * @param  Carbon_Fields\Container\Container $container
	 * @return array<string>
	 */
	public function filter_user_meta_container_dynamic_condition_types( $condition_types, $container_type, $container ) {
		return array_merge(
			$condition_types,
			array( 'user_role' )
		);
	}
}


1			<?php
2
3			namespace Carbon_Fields\Provider;
4
5			use Carbon_Fields\Pimple\Container as PimpleContainer;
6			use Carbon_Fields\Pimple\ServiceProviderInterface;
7			use Carbon_Fields\Container\Condition\Factory as ConditionFactory;
8			use Carbon_Fields\Container\Fulfillable\Fulfillable_Collection;
9
10			class Container_Condition_Provider implements ServiceProviderInterface {
11
12			/**
13			* Install dependencies in IoC container
14			*
15			* @param PimpleContainer $ioc
16			*/
17			public function register( PimpleContainer $ioc ) {
18			$this->install_conditions( $ioc );
19			$this->install_comparers( $ioc );
			1 ignored issue – show Unused Code introduced 2017-05-16 09:10 UTC by Report Bug Copy Issue Report The call to the method `Carbon_Fields\Provider\C...er::install_comparers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
20			$this->install_translators( $ioc );
			1 ignored issue – show Unused Code introduced 2017-05-16 09:10 UTC by Report Bug Copy Issue Report The call to the method `Carbon_Fields\Provider\C...::install_translators()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
21			$this->install_container_conditions( $ioc );
22			}
23
24			/**
25			* Install all codition types and the condition factory
26			*
27			* @param PimpleContainer $ioc
28			*/
29			protected function install_conditions( $ioc ) {
30			$ioc['container_condition_factory'] = function( $ioc ) {
31			return new ConditionFactory( $ioc['container_conditions'] );
32			};
33
34			$ioc['container_condition_fulfillable_collection'] = $ioc->factory( function( $ioc ) {
35			return new Fulfillable_Collection( $ioc['container_condition_factory'], $ioc['container_condition_translator_array'] );
36			} );
37
38			$ioc['container_conditions'] = function( $ioc ) {

htmlburger / carbon-fields

Push — milestone/2_0/react-ui ( 5b168c...b737dc )

Container_Condition_Provider C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like