Incorrect_Syntax_Exception::raise() - Code Metrics - Inspection of "handling exceptions gracefully when WP_DEBUG is di..." - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a3db22...aec616 )

by Marin

created 2016-01-21 16:12 UTC

Incorrect_Syntax_Exception::raise() A

↳ Parent: Incorrect_Syntax_Exception

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	3
eloc	8
nc	4
nop	2

<?php 

namespace Carbon_Fields\Exception;

class Incorrect_Syntax_Exception extends \Exception {

	static $errors = array();
class A {
    var $property;
}
	public static $throw_errors = WP_DEBUG;

	/**
	 * Throw an exception when WP_DEBUG is enabled, and show a friendly admin notice otherwise
	 */
	static function raise( $message, $code = null ) {

		if ( empty( self::$errors ) ) {
			add_action( 'admin_notices', array( __NAMESPACE__ . '\\Incorrect_Syntax_Exception', 'print_errors' ) );
		}

		$exception = new self( $message, $code );

		if ( self::$throw_errors ) {
			throw $exception;
		} else {
			self::$errors[] = $exception;
		}
	}

	static function print_errors() {

		$hideErrorsCookieName = 'crbErrHide';

		// Disable cookies
		if ( isset( $_COOKIE[ $hideErrorsCookieName ] ) ) {

			return;
		}

		$errors = self::$errors;
		$plural = count( $errors ) === 1 ? "" : "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

		include \Carbon_Fields\DIR . '/templates/Exception/incorrect-syntax.php';
	}

}

1			<?php
2
3			namespace Carbon_Fields\Exception;
4
5			class Incorrect_Syntax_Exception extends \Exception {
6
7			static $errors = array();
			0 ignored issues – show Coding Style introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$errors`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
8			public static $throw_errors = WP_DEBUG;
9
10			/**
11			* Throw an exception when WP_DEBUG is enabled, and show a friendly admin notice otherwise
12			*/
13			static function raise( $message, $code = null ) {
			0 ignored issues – show Best Practice introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
14			if ( empty( self::$errors ) ) {
15			add_action( 'admin_notices', array( __NAMESPACE__ . '\\Incorrect_Syntax_Exception', 'print_errors' ) );
16			}
17
18			$exception = new self( $message, $code );
19
20			if ( self::$throw_errors ) {
21			throw $exception;
22			} else {
23			self::$errors[] = $exception;
24			}
25			}
26
27			static function print_errors() {
			0 ignored issues – show Best Practice introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28			$hideErrorsCookieName = 'crbErrHide';
29
30			// Disable cookies
31			if ( isset( $_COOKIE[ $hideErrorsCookieName ] ) ) {
			0 ignored issues – show introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report Due to using Batcache, server side based client related logic will not work, use JS instead. Loading history...
32			return;
33			}
34
35			$errors = self::$errors;
36			$plural = count( $errors ) === 1 ? "" : "s";
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2016-01-21 16:40 UTC by Report Bug Copy Issue Report The string literal `s` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
37
38			include \Carbon_Fields\DIR . '/templates/Exception/incorrect-syntax.php';
39			}
40
41			}

htmlburger / carbon-fields

Push — master ( a3db22...aec616 )

Incorrect_Syntax_Exception::raise() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like